[spec-enforcer] Enforce specifications for jsonutil, scanfindings - #56362
Open
github-actions[bot] wants to merge 1 commit into
Open
[spec-enforcer] Enforce specifications for jsonutil, scanfindings#56362github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification Test Enforcement
This PR adds/updates specification-driven tests for the following packages:
jsonutilscanfindingsactionpinsTest Derivation
All tests are derived from README.md specifications, not from implementation source code.
Validation
go build ./pkg/jsonutil/...go test -v -run 'TestSpec' ./pkg/jsonutil/go build ./pkg/scanfindings/...go test -v -run 'TestSpec' ./pkg/scanfindings/make fmtwas attempted, but repository formatting could not complete becausemake fmt-cjsfailed in this environment before the final aggregate target finished.Spec-Implementation Mismatches
scanfindingsREADME.md documents exportedSort(findings []Finding)andCountAtLeast(findings []Finding, min SeverityLevel) intfunctions, but those exported functions are not present in the current package source. The generated spec test file records this asSPEC_MISMATCH.Round-Robin State
actionpins,jsonutil,scanfindingssemverutil,setutil,sliceutilAuto-generated by Package Specification Enforcer workflow
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
registry.npmjs.orgTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.