Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to upgrade the repository’s Go toolchain from 1.23.0 to 1.25.9 across local tooling and containerized workflows.
Changes:
- Bumps the preferred Go version and associated checksums in
script/ensure-go-installed. - Updates test/build scripts and Docker test invocation to support
go testflags (notably-short). - Skips several test suites when running in
testing.Short()mode.
Show a summary per file
| File | Description |
|---|---|
| script/test | Runs gofmt with consistent args, scopes diff check to go/, forwards CLI args to go test. |
| script/ensure-go-installed | Updates preferred Go version/checksums; adjusts macOS install extraction step. |
| go/logic/streamer_test.go | Skips suite in short mode. |
| go/logic/migrator_test.go | Skips suite in short mode. |
| go/logic/applier_test.go | Skips suite in short mode. |
| Dockerfile.test | Updates base Go image and runs tests in short mode by default. |
| Dockerfile.packaging | Updates base Go image for packaging builds. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 7/7 changed files
- Comments generated: 5
susanzhang27
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade go version 1.23.0 -> 1.25.9.
Also fix Dockerfile.test to run unit tests (no integration tests)