Replace pagination args with cursor pagination#1364
Closed
SamMorrowDrums wants to merge 6 commits intomainfrom
Closed
Replace pagination args with cursor pagination#1364SamMorrowDrums wants to merge 6 commits intomainfrom
SamMorrowDrums wants to merge 6 commits intomainfrom
Conversation
- Replace page/perPage parameters with single cursor parameter - Fix page size at 10 items (fetch 11 to detect more data) - Add cursor parsing and encoding functions - Update all paginated tools to return items, moreData, and cursor fields - Preserve existing metadata for search results (totalCount, etc.) This addresses issue #1362 by providing deterministic cursor values that models can pass back directly without inferring page numbers.
Simplify workflow jobs pagination to directly handle jobs array instead of trying to parse CallToolResult text content.
Update all tool snapshots to reflect the new cursor parameter replacing page/perPage parameters.
- Updated all tests to handle new paginated response format with items, moreData, and cursor fields - Updated CreatePaginatedSearchResponse to handle 'issues' field for SearchIssues - Fixed SearchIssues and SearchPullRequests tests to unmarshal paginated responses correctly - Updated per_page expectations from 30/10 to 11 (CursorFetchSize) in all test mocks - Fixed ListIssues test to check for GraphQL 'after' cursor instead of REST 'cursor' - All tests now passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/github/copilot-agent-services/issues/868
A possible implementation of cursor pagination arguments, to replace the explicit pagination control, and make it clear to the model how to get more data.