Fix handling of multi path resources#1458
Merged
omgitsads merged 9 commits intogithub:omgitsads/go-sdkfrom Nov 20, 2025
Merged
Conversation
…cp-server into omgitsads/go-sdk-repo-resources
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of multi-path resources in URI templates by properly extracting path components from uritemplate.Value. The issue was that String() doesn't work for multi-segment paths with capture groups - the proper approach is to check if the value is a list and handle both cases accordingly.
Key Changes:
- Fixed path extraction logic in
RepositoryResourceContentsHandlerto handle both single path values and multi-segment paths usingList()andString()methods - Added new utility functions for creating tool results in
pkg/utils/result.go - Migrated from
mark3labs/mcp-gotomodelcontextprotocol/go-sdkthroughout the codebase - Updated third-party license files to reflect dependency changes
Reviewed Changes
Copilot reviewed 90 out of 91 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/github/repository_resource.go |
Fixed multi-path URI template handling by checking for list values and joining path components |
pkg/github/repository_resource_test.go |
Refactored tests to use new SDK patterns and added multi-path test case |
pkg/utils/result.go |
Added utility functions for creating MCP tool results |
pkg/toolsets/toolsets.go |
Migrated to new MCP SDK with updated type definitions |
pkg/log/io.go |
Added Close method to IOLogger |
pkg/github/*.go |
Large-scale migration from old MCP SDK to new one |
| Third-party license files | Updated to reflect dependency changes (removed old deps, added new ones) |
| return mcp.NewToolResultError(err.Error()), nil | ||
| } | ||
| func GetDependabotAlert(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Tool, mcp.ToolHandlerFor[map[string]any, any]) { | ||
| tool := mcp.Tool{ |
There was a problem hiding this comment.
This definition of tool is never used.
| return mcp.NewToolResultError(err.Error()), nil | ||
| } | ||
| func ListDependabotAlerts(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Tool, mcp.ToolHandlerFor[map[string]any, any]) { | ||
| tool := mcp.Tool{ |
There was a problem hiding this comment.
This definition of tool is never used.
| return mcp.NewToolResultError(err.Error()), nil | ||
| } | ||
| func ListGists(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Tool, mcp.ToolHandlerFor[map[string]any, any]) { | ||
| tool := mcp.Tool{ |
There was a problem hiding this comment.
This definition of tool is never used.
| return mcp.NewToolResultError(err.Error()), nil | ||
| } | ||
| func GetGist(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Tool, mcp.ToolHandlerFor[map[string]any, any]) { | ||
| tool := mcp.Tool{ |
There was a problem hiding this comment.
This definition of tool is never used.
| return mcp.NewToolResultError(err.Error()), nil | ||
| } | ||
| func CreateGist(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Tool, mcp.ToolHandlerFor[map[string]any, any]) { | ||
| tool := mcp.Tool{ |
There was a problem hiding this comment.
This definition of tool is never used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1457, as I missed that
uritemplate.Valueseparates the capture group andString()doesn't work.