fix(pull_requests): validate required params in add_comment_to_pending_review#2770
Open
syf2211 wants to merge 1 commit into
Open
fix(pull_requests): validate required params in add_comment_to_pending_review#2770syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
…g_review Replace mapstructure.WeakDecode with RequiredParam/RequiredInt checks so missing arguments like owner return a clear validation error instead of running the GraphQL query with zero values. Fixes github#2718
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate required arguments in
add_comment_to_pending_reviewbefore calling the GraphQL API, returning clearmissing required parametererrors consistent with other pull request tools.Motivation
When a required argument such as
ownerwas omitted, the handler usedmapstructure.WeakDecodeand proceeded with zero values. The downstream GraphQL call then failed with a confusing repository-resolution error instead of indicating which argument was missing.Fixes #2718
Changes
mapstructure.WeakDecodeinAddCommentToPendingReviewwithRequiredParam/RequiredInt/OptionalIntParam/OptionalParamownerandpathTests
go test ./pkg/github/... -run TestAddPullRequestReviewCommentToPendingReview -count=1 ./script/lintAll tests pass; lint reports 0 issues.
Notes
The same
WeakDecode-without-validation pattern also exists incopilot.goanddiscussions.go; those are out of scope for this focused fix as noted in the issue.