get_me return concise user response#638
Merged
SamMorrowDrums merged 4 commits intomainfrom Jul 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the get_me tool to return a slimmed-down MinimalUser instead of the full User object, aligning it with search_users output.
- Map and return only selected fields (
Login,ID,ProfileURL,AvatarURL) inGetMe - Update tests to unmarshal into
MinimalUserand assert onLoginandProfileURL - Remove assertions for full-user fields (
Name,Email,Bio,Type)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/github/context_tools.go | Build and marshal a MinimalUser with only login, ID, and URLs |
| pkg/github/context_tools_test.go | Switch test to expect MinimalUser and update assertions accordingly |
Comments suppressed due to low confidence (1)
pkg/github/context_tools_test.go:126
- Add assertions to verify
returnedUser.IDandreturnedUser.AvatarURLagainst the expected values so that all fields inMinimalUserare covered by tests.
assert.Equal(t, *tc.expectedUser.HTMLURL, returnedUser.ProfileURL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update get_me tool to return a marshalled
MinimalUserinstead of a fullUserobject, and extendMinimalUserwith an optional nestedUserDetails.github-mcp-server/pkg/github/search.go
Lines 158 to 165 in dd62f8d
search_userstool is unchanged, it omits the nested details fieldExample
{ "login": "LuluBeatson", "id": 59149422, "profile_url": "https://github.com/LuluBeatson", "avatar_url": "https://avatars.githubusercontent.com/u/59149422?v=4", "details": { "name": "Lulu", "blog": "lulubeatson.com", "location": "London, UK", "public_repos": 31, "public_gists": 1, "followers": 0, "following": 5, "created_at": "2019-12-22T21:15:47Z", "updated_at": "2025-06-05T06:41:06Z" } }