Ensure that Nokogiri is at least at 1.18.4#1946
Closed
maxbeizer wants to merge 3 commits intogithub:masterfrom
Closed
Ensure that Nokogiri is at least at 1.18.4#1946maxbeizer wants to merge 3 commits intogithub:masterfrom
maxbeizer wants to merge 3 commits intogithub:masterfrom
Conversation
Update Nokogiri gem version to at least 1.18.4. * **Gemfile** - Add `nokogiri` gem with version constraint `~> 1.18.4`. * **github-markup.gemspec** - Update `nokogiri` development dependency version constraint to `~> 1.18.4`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/github/markup?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Nokogiri gem version to at least 1.18.4 to ensure compatibility and improved functionality.
- Upgrade Nokogiri version in the development dependencies of github-markup.gemspec
- Add Nokogiri gem with the updated version in the Gemfile
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| github-markup.gemspec | Updated nokogiri development dependency version constraint to ~> 1.18.4 |
| Gemfile | Added nokogiri gem with version constraint ~> 1.18.4 |
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Contributor
Author
|
superseded by #1947 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Nokogiri gem version to at least 1.18.4.
Gemfile
nokogirigem with version constraint~> 1.18.4.github-markup.gemspec
nokogiridevelopment dependency version constraint to~> 1.18.4.For more details, open the Copilot Workspace session.