fix: handle TOCTOU race in list_runs state file read - #3838
Open
Quratulain-bilal wants to merge 239 commits into
Open
fix: handle TOCTOU race in list_runs state file read#3838Quratulain-bilal wants to merge 239 commits into
Quratulain-bilal wants to merge 239 commits into
Conversation
Remove exists() check and wrap open/load in try/except to handle the case where state.json is deleted between the check and open. A missing or corrupt state file now skips that run instead of crashing the entire list_runs operation.
* chore: bump version to 0.14.4 * chore: begin 0.14.5.dev0 development --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…thub#3793) PromptStep._try_dispatch runs `subprocess.run(exec_args, ...)` with an UNRESOLVED argv[0] -- a bare name like `claude`. On Windows subprocess.run calls CreateProcess, which does not consult PATHEXT, so an agent CLI installed as a `.cmd`/`.bat` shim (the usual npm layout) raises FileNotFoundError [WinError 2]. That OSError is swallowed by the method's `except OSError: return None`, and execute() then reports "CLI not found or not installed" -- even though the step's own preflight `shutil.which(...)` two lines earlier just found it. The sibling path does not have this bug: IntegrationBase.dispatch_command (used by the `command` step) resolves argv[0] through shutil.which first, added in 8e5643d for exactly this reason. Same machine, same integration, CLI present as a .cmd shim: type: prompt -> failed "integration 'claude' CLI not found or not installed." type: command -> completed Primitive confirmation: bare `subprocess.run(["fakeagent"])` raises [WinError 2] while `subprocess.run([shutil.which("fakeagent")])` runs fine. Reuse the path the preflight already resolved (`fallback_cli_path`) instead of calling which() again, so the shim is executed. On POSIX it is the same executable, so behaviour is unchanged there. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…#3826) * fix(presets): escape installed preset metadata in Rich output `preset.yml` is user-editable, but the installed-preset display paths interpolated its fields straight into `console.print`, where Rich parses `[...]` as a style tag. PR github#3773 escaped the *catalog* branch of these commands; the local branch was left behind, so the same field rendered correctly from a catalog and incorrectly once installed. Two failure modes: - Silent data loss: a description `Does [stuff] nicely` renders as `Does nicely`. - Hard crash: an unbalanced tag such as `Broken [/red] tag` raises `rich.errors.MarkupError`, aborting `preset list`/`preset info` with a traceback and exit code 1 — the preset cannot be inspected at all. Escaped the installed branch of `preset list` (name/id/version/ description) and `preset info` (name/id/version/description/author/tags/ repository/license plus the per-template description), and the catalog branch's tags join that the earlier sweep missed. `preset resolve` was unescaped throughout: it echoes its own `template_name` argument, so `preset resolve 'no[/red]such'` crashed on user input alone. Also escaped the resolved paths, layer sources, and composition-error message. Separately, the composition chain's `[{strategy_label}]` was consumed as a style tag, so every chain line printed a blank label instead of `[base]`/`[append]`. Escaped the literal bracket as `\[`, matching the step-graph line in `workflow info`. Regression tests in `TestInstalledPresetRichMarkup` cover all five behaviours; each fails before this change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(presets): cover catalog tags and resolve escapes Addresses Copilot review feedback on github#3826: two escapes added by the previous commit had no regression assertion, so they could be reverted with the suite still green. - `test_info_escapes_catalog_markup` asserted every catalog field except `tags`; the new tag assertion only exercised an installed preset. Assert the rendered tags join in the catalog branch too. - The escapes on `preset resolve`'s resolved path, layer source, and composition-error message were untested. Add three cases patching `PresetResolver` to feed markup through the top-layer line, the no-layer `resolve_with_source` fallback, and a markup-bearing `resolve_content` exception. Test-the-test: with `_commands.py` reverted to the pre-fix revision, 9 of the 10 markup tests fail (was 5); with the fix applied all 10 pass. A closing tag cannot be embedded in the mocked path — `Path` treats the `/` as a separator — so the path assertion uses an opening tag for the swallowing case and the unbalanced tag rides on the adjacent `source` field on the same line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-by: Claude Code (model: claude-opus-5, under direct human supervision) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…nsion cannot break `extension list` (github#3797) ExtensionManifest.REQUIRED_FIELDS only checks key PRESENCE, so a section that is written but left empty (`provides:` -> None) or given the wrong shape (`provides: []`) passes it and then fails on first use: extension: null -> TypeError: argument of type 'NoneType' is not iterable requires: null -> TypeError: argument of type 'NoneType' is not iterable provides: null -> AttributeError: 'NoneType' object has no attribute 'get' provides: [] -> AttributeError: 'list' object has no attribute 'get' Neither is a ValidationError, so both escape the callers that already handle malformed manifests. list_installed() catches ValidationError only and has a deliberate "Corrupted extension" fallback, so a single bad extension took down the whole command -- reproduced end-to-end: before: specify extension list -> exit 1, raw AttributeError, no output after: specify extension list -> exit 0, the good extension listed, the bad one shown as "Corrupted extension" Add an isinstance guard for each required section, mirroring the nested guards already in this function ("Invalid provides.commands: expected a list", "Invalid hooks: expected a mapping") and _load_yaml's document-root check. Only the three REQUIRED sections lacked one. `provides: {}` is unaffected: it is a well-shaped mapping, so an extension that provides only hooks still validates, and with no hooks it keeps the pre-existing "must provide at least one command or hook" message. Both are locked by tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…#3704) * feat: first-class agent-native runtime hooks for integrations * refactor: rework integration events per maintainer review - Rename hooks terminology to 'events' (events:, --events flag, events.py). - Use snake_case names for canonical events consistent with spec-kit vocabulary. - Fold event config adapters into integration classes via class attributes (CANONICAL_TO_NATIVE, events_config_file, events_format). - Lift event command-script resolution to core 'specify event run' command. - Split events sourcing from integration config writing. - Support first-class Copilot CLI events JSON generation under '.github/hooks/speckit.json'. - Rewrite and expand full test suite under 'tests/integrations/test_events.py'. Assisted-by: opencode (model: litellm/gemini-3.5-flash, autonomous) * fix(events): resolve ruff lint errors blocking CI Address Copilot review finding github#18 (src/specify_cli/__init__.py event-command import missing # noqa: E402), github#19 (unused console import in commands/event.py), and github#20 (unused patch/yaml/Path/integration imports in test_events.py). Also fix two stray F541 f-string prefixes in _build_opencode_plugin that ruff flagged in the same job. Bump dev version 0.14.2.dev0 -> 0.14.2.dev1 and add a CHANGELOG entry per the AGENTS.md convention for Specify CLI __init__.py changes. Refs: PR github#3704 Copilot inline review (findings github#18, github#19, github#20) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): make generated native hooks actually execute Address Copilot review findings that left generated event hooks inert or schema-invalid after the rework: - github#2: the resolved events map now carries an ordered list of handlers per event (dict[str, list[dict]]) so two extensions declaring the same event both run instead of the last one silently winning. collect_extension_events accumulates; every adapter emits one native entry per handler. - github#6: Claude/Gemini/Qwen/Devin/Tabnine native schema accepts a single 'command' string, not command+args. Each adapter now renders one complete shell invocation of the dispatcher via _dispatcher_command(). - github#7: Gemini measures hook timeouts in milliseconds; add events_timeout_unit attr and _native_timeout() so the 60s default becomes 60000ms instead of terminating the dispatcher after 60ms. - github#4: _resolve_event_command_argv() replaces _extract_script_path() — scripts: values are command strings (e.g. 'scripts/bash/setup-plan.sh --json'), not bare paths. Resolves the project's sh/ps/py variant, splits safely into argv, and prepends the interpreter for .py. - github#5: bundled-template fallback now uses _locate_core_pack()/_repo_root() (core_pack/commands, not the non-existent core_pack/templates/commands). - github#16: all formatters use IntegrationBase.resolve_python_interpreter() so generated commands honor the project venv and never hard-code python3 (absent on Windows). The opencode TS plugin bakes in the same resolved interpreter. - github#13: opencode TS plugin runEvent() now throws on failure instead of process.exit(2), which killed the OpenCode host process; only the failing hook is rejected. - github#21: user YAML override is validated (event names, non-empty command strings) before returning; a malformed override is warned about and ignored rather than crashing installation on cfg.get(). Bump dev version 0.14.2.dev1 -> 0.14.2.dev2 (gemini/__init__.py change) and add a CHANGELOG entry. Refs: PR github#3704 Copilot inline review (findings github#2, github#4, github#5, github#6, github#7, github#13, github#16, github#21) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): merge/teardown idempotency and data safety Address Copilot review findings on native-config merge and teardown: - github#9: _has_marker now recurses into nested 'hooks' arrays so a matcher-group containing Specify-owned inner hooks is recognized and replaced on upgrade instead of accumulating duplicates. - github#11: _merge_json_fragment strips ALL Specify-marked entries from every event before adding the new set, so an override that drops an event (pre_tool_use -> stop) removes the stale marked entry instead of leaving it active. - github#3: an empty resolved map (--events false / disabled override) now runs the native-config removal path instead of early-returning, so prior Specify hooks are stripped. The shared dispatcher is left untouched (github#10). - github#14: teardown deletes a Spec-Kit-created config that is now empty of user content (rather than leaving '{}' that confused manifest.uninstall()), while preserving pre-existing configs with user hooks/settings. - github#10: the shared .specify/events.py dispatcher is deleted only when no other installed event-capable integration's manifest still references it, so uninstalling one multi-install integration doesn't break the others. - github#8: Copilot's .github/hooks/speckit.json now merges owned entries (with markers) into a pre-existing file instead of overwriting, and teardown removes only owned entries (deleting the file when no user hooks remain). - github#22/github#23: JSON/JSONC parse failures in native configs (Claude/Cursor/etc. and opencode.json) abort the merge with a warning instead of resetting user content to '{}'. - github#12: write destinations are validated (symlinked-ancestor rejection + containment) before any bytes are written, so a symlinked .specify or native config directory can't redirect writes outside the repository. Refs: PR github#3704 Copilot inline review (findings github#3, github#8, github#9, github#10, github#11, github#12, github#14, github#22, github#23) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): honor enabled flag, refresh on extension lifecycle, strict command validation Address Copilot review findings on sourcing, validation, and lifecycle: - github#1: collect_extension_events now honors the extension registry's 'enabled' flag — a disabled extension's events are skipped so disabling an extension actually deactivates its runtime hooks. Adds refresh_integration_events(), wired into extension add/remove/enable/disable, so installing, removing, enabling, or disabling an extension regenerates each installed event-capable integration's native event config (the documented install-after-init flow is no longer inert, and disabled/removed extension events are stripped). - github#17: validate_events now requires 'command' to be a non-empty string, not merely truthy, so a value like 'command: [foo]' is rejected at manifest load instead of rendering into invalid native configuration. - github#15: updated PR github#3704 description to the implemented events terminology (.specify/events.py, events:, --events, integration-events.yml) replacing the stale bridge.py / runtime_hooks: / --hooks false / integration-hooks.yml references that no longer match the shipped API. (github#21 — user YAML override validation — was addressed in the prior tier.) Refs: PR github#3704 Copilot inline review (findings github#1, github#15, github#17) Assisted-by: opencode (model: glm-5.2, autonomous) * revert: drop CHANGELOG.md/pyproject.toml version bumps from events fixes Per maintainer request, the events PR no longer carries CHANGELOG entries or pyproject version revs. This restores both files to their pre-PR (da6c20d) state: pyproject.toml back to 0.14.2.dev0 and the [Unreleased] block removed from CHANGELOG.md. The AGENTS.md version-rev convention for __init__.py changes is intentionally waived for this PR by maintainer decision. This also clears the pending merge conflicts with upstream/main on these two files (upstream's 0.14.2 release commit c0fe0e4): our side now makes no net change to them relative to the merge-base, so a future upstream merge takes theirs on both without conflict. Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): compose --events into Copilot/Devin options() (github#8, github#9) Copilot and Devin are event-capable, but their options() overrides returned only --skills without calling super(), so the base class never declared --events. The documented --integration-options "--events false" opt-out was therefore rejected as unknown for both adapters. Both now compose with super().options() (mirroring Codex and Cursor) so --events is declared alongside --skills. Added a TestEventCapableOptionsCompo sition test class asserting --events appears in Copilot, Devin, Cursor, and Codex options() output. Refs: PR github#3704 Copilot review 4790195897 (findings github#8, github#9) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): Cursor version field, matcher grouping, Copilot cross-OS Address three Copilot review findings on native-config generation: - github#7: Cursor's .cursor/hooks.json schema requires top-level "version": 1, but json-flat used _merge_json_fragment() which only writes hooks, so a freshly generated file was missing the required schema version. Added a version kwarg to _merge_json_fragment (preserving a user's value if present) and the Cursor json-flat branch now passes version=1. - S3: json-nested placed all handlers under the first handler's matcher, so two extensions registering the same event with different matchers both ran for the first matcher and neither for the later. Handlers are now grouped by distinct matcher, emitting one matcher-group per matcher (handlers sharing a matcher stay in one group). - S4: Copilot's bash and powershell fields both received the same host-resolved command, so a config generated on Linux wrote a POSIX venv path into the PowerShell hook (and vice-versa). _dispatcher_command gains a target_os kwarg; Copilot now emits an independent POSIX interpreter (python3) for bash and a Windows interpreter (python) for powershell, so the checked-in config works on either OS. Tests: added TestCursorJsonWriting (version present + preserved) and matcher-grouping regressions (per-distinct-matcher, shared-matcher); updated the Copilot generation test to assert bash != powershell with OS-appropriate interpreters. Refs: PR github#3704 Copilot review 4790195897 (findings github#7, S3, S4) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): anchor py scripts and prefix ps launcher in command runner Address two Copilot review findings on the core command runner: - S2: the py variant called build_python_invocation() on the raw scripts: command string, which left 'scripts/...' anchored at the project root instead of under .specify/ (or .specify/extensions/<id>/). Every event command in a project configured with --script py launched a nonexistent project-root path. The py branch now shares the same base-anchoring as sh/ps and prepends the resolved interpreter as argv (no shell quoting needed for subprocess.run(shell=False)). - S6: the ps variant returned the .ps1 path as the executable, but Windows subprocess.run(shell=False) cannot execute a PowerShell script directly, so event dispatch failed on the default Windows script type. The ps branch now prefixes argv with 'pwsh -File' (PowerShell 7+), falling back to 'powershell -File' (Windows PowerShell) when pwsh is absent. Tests: added test_py_variant_anchored_under_specify and test_ps_variant_prefixed_with_powershell_launcher covering the new argv shapes (interpreter + .specify-anchored path; launcher -File + path). Refs: PR github#3704 Copilot review 4790195897 (findings S2, S6) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): skip-tracking on parse fail, drop dispatcher claim on retain, honor --events false in refresh, preserve layers on invalid override Address four Copilot review findings on merge/teardown/refresh safety: - S5: _merge_json_fragment/_merge_opencode_plugin_ref/_merge_copilot_json now return bool (wrote). Install branches skip manifest.record_existing() and created.append() when a merge was skipped on parse failure, so a user's JSONC/malformed native config is not tracked and manifest.uninstall() can't later delete the untouched file. - S1: remove_integration_events now drops this integration's manifest claim on the shared dispatcher (manifest.remove) even when the file is retained because another integration references it. Previously the retained file stayed tracked, so the subsequent manifest.uninstall() in teardown() saw the matching hash and deleted the file another integration still depended on. The unit test now exercises full teardown() (not just remove_integration_events) to cover the gap. - S7: refresh_integration_events reads each integration's stored parsed_options via _resolve_integration_options and passes them to resolve_events, so a persisted --events false is honored across extension add/enable/disable instead of being discarded (which re-enabled events the user had disabled). - github#10: an invalid override entry now abandons the entire override and keeps the accumulated built-in + extension layers, instead of resetting resolved_override to {} and assigning that empty map to events (which silently disabled all hooks on a single typo). Only a fully-valid override (including an explicit events: {}) replaces the prior layers. Tests: added TestOverridePreserveLayers (invalid entry keeps layers; explicit empty disables), TestSkippedMergeNotTracked (JSONC not recorded), and TestDispatcherManifestClaimDroppedOnRetain (full teardown keeps dispatcher when another integration references it). Added S7 refresh-honors-events-false regression. Refs: PR github#3704 Copilot review 4790195897 (findings S5, S1, S7, github#10) Assisted-by: opencode (model: glm-5.2, autonomous) * test(extensions): update stale validation-message assertion The 'no commands/hooks/events' validation message changed to 'Extension must provide at least one command, hook, or event' when the events feature added a third provider kind, but test_no_commands_no_hooks still matched the old 'must provide at least one command or hook' text and failed on every CI job. Update the regex to the current message. Refs: PR github#3704 CI failure (test_extensions.py:579) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): forced-teardown data safety, manifest-driven command resolution, toml teardown safe-dest Address three findings from Copilot review 4791088500: - S9: _remove_native_event_hooks now unconditionally drops this integration's manifest claim on the native config, not only when the file was deleted. Previously a config whose owned entries were cleaned but user content retained stayed tracked, so teardown(force=True) -> manifest.uninstall( force=True) deleted the entire user-owned settings file. This is the config-file mirror of the earlier shared-dispatcher fix. - S8: _find_command_template resolved extension event commands via a broken registry lookup (the registry stores per-agent registered_commands name-lists, not a {name, file} map) and a file-stem scan that only matched when the .md stem equaled the command name. A manifest mapping speckit.selftest.extension -> commands/selftest.md resolved as missing. It now enumerates installed extensions via ExtensionManager.get_extension() and matches provides.commands[].name -> file, with the directory scan and core-template lookups kept as fallbacks. - R3: _remove_toml_entries now validates the destination with _ensure_safe_destination before read/write, matching the merge path, so a symlink swap of .codex/config.toml after install can't make teardown overwrite a file outside the project. Tests: forced full teardown preserves a user settings file; an extension command whose file stem differs from its name resolves via the manifest; TOML teardown rejects a symlinked config destination. Refs: PR github#3704 Copilot review 4791088500 (findings S8, S9, R3) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): subprocess cwd, shell quoting, TOML matcher escaping, Tabnine ms Address four findings from Copilot review 4791088500: - R1: the generated dispatcher and resolve_and_run_event_command now run their subprocesses with cwd set to the dispatcher-derived project root. Previously 'specify event run' (and the resolved script) inherited the agent's working directory, but event_run resolves the project via Path.cwd(), so a hook fired from a subdirectory targeted the wrong project and reported the command missing. - R2: _dispatcher_command now shell-quotes each component (interpreter, command, event) for the target shell (POSIX via shlex.quote; PowerShell via single-quoted literals with doubled quotes). An interpreter path containing spaces or an extension/override command containing shell metacharacters is passed as a single argument instead of being reinterpreted by the native hook shell. Claude's prefix is left unquoted so the shell still expands it (prefix + relative path are fixed, safe strings). - R4: the Codex TOML matcher is now rendered through the shared TOML escaper like command, so a matcher containing a quote/backslash/newline/control character no longer produces malformed config.toml. - R5: Tabnine declares events_timeout_unit='ms' (its hook schema mirrors Gemini's BeforeTool/AfterTool), so the 60s default becomes 60000ms instead of timeout: 60 (60 ms), which would terminate the dispatcher immediately. Tests: cwd-forced execution from a subdirectory; POSIX/PowerShell quoting of metacharacter and space-bearing components; TOML matcher with a quote parses cleanly; Tabnine timeout converts to 60000. Updated the Copilot generation test for the new quoted args. Refs: PR github#3704 Copilot review 4791088500 (findings R1, R2, R4, R5) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): POSIX dispatcher path constant + platform-agnostic tests Three Windows test failures, one a real cross-OS bug: - W1 (bug): EVENTS_DISPATCHER_REL was str(Path('.specify')/'events.py'), which yields '.specify\events.py' on Windows. Manifest keys are stored in POSIX form (.as_posix()), so 'dispatcher_rel in manifest.files' was always False on Windows: the shared-dispatcher manifest-claim drop was skipped and manifest.uninstall(force=True) deleted the dispatcher another integration still depended on. Make it a POSIX constant (.as_posix()) so it matches manifest keys on every platform. - W2/W3 (tests): the py/ps argv assertions used endswith() and an exact launcher-name set that broke on Windows backslash paths and the pwsh.EXE/full-path launcher returned by shutil.which. Compare in POSIX form and match the launcher by case-insensitive stem. Refs: PR github#3704 Windows CI failures Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): override layer preservation, matcher validation, event command-ref canonicalization Address four Copilot review findings: - C4: a malformed override handler (e.g. "stop: []" or "stop: bad-value") normalizes to no handlers. Previously the entry was skipped and the override still adopted, so an override whose only entry was malformed silently disabled every built-in and extension hook. The empty-handler case now abandons the whole override (keeps prior layers); an explicit "events: {}" (no entries) remains a valid disable. - C6: a non-mapping integration entry (e.g. "claude: bad") was coerced to "events: {}" and treated as a valid explicit disable. It now warns and abandons the override, keeping the accumulated layers. Only an explicitly present, mapping-valued "events" field replaces the prior layers. - C10: matcher is now validated as a string (or absent) in both validate_events (manifest) and _validate_resolved_event (override). A non-string matcher such as "matcher: []" previously passed validation but crashed by_matcher.setdefault(matcher, ...) with TypeError: unhashable type, aborting init or refresh. - C11: ExtensionManifest._validate now applies the same rename + alias-lift canonicalization to event command references that it already applies to hook references. An event referencing an auto-corrected command (e.g. my-ext.boot -> speckit.my-ext.boot) previously kept the obsolete name, so dispatch reported no command and the event silently no-oped. Tests: empty-handler/non-mapping override preserves layers; non-string matcher rejected in manifest and abandoned in override; event command ref lifted to canonical form with a warning. Refs: PR github#3704 Copilot review (findings C4, C6, C10, C11) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): protect shared dispatcher from stale cleanup, delete Cursor version stub, non-destructive refresh Address three Copilot review findings: - C3: the shared .specify/events.py dispatcher is now in events_stale_exclusions(). It is written into every event-capable integration's manifest but reference-counted across them; an upgrade with --events false omits events.py from the new manifest, so the generic stale pass would delete it without the refcount check, breaking any other installed event-capable integration. Its deletion is left to remove_integration_events(), which checks the refcount. - C5: _remove_json_entries now deletes a Spec-Kit-created Cursor file that retains only {"version": 1} after all owned hooks are removed (we added the version field), mirroring _remove_copilot_entries. Previously the generic remover only deleted a literally-empty object, so clean teardown left a generated stub behind. - C12: refresh_integration_events now resolves first and calls install_integration_events once, instead of running the destructive _remove_native_event_hooks pre-step before resolution. A later failure (invalid destination, write error, formatter error) no longer destroys the working native config before the new one is written. install_integration_events already removes stale Specify-marked entries and handles an empty map (stripping prior hooks), so the pre-step was both unsafe and redundant. Tests: dispatcher in stale exclusions; Cursor version-only stub deleted on teardown; refresh failure preserves the pre-existing config (no pre-strip). Refs: PR github#3704 Copilot review (findings C3, C5, C12) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): host target uses POSIX quoting, Claude dispatcher double-quoted, & for windows Address two Copilot review findings on the shell-quoting added in the prior round (R2): - C1: _shell_quote("host") now always uses POSIX shlex.quote, not PowerShell single-quoting on Windows. The single-command-string formats (Claude/Gemini/Qwen/Devin/Tabnine) are run via the agent's POSIX-ish shell (Git Bash on Windows), and a single-quoted 'python' is not invoked as a command by PowerShell without the call operator — so generated hooks failed to launch the dispatcher on Windows. Safe tokens pass through bare (python3, speckit.ext.cmd) on every platform. PowerShell single-quoting is now used only for the explicit target_os="windows" (Copilot's powershell field), where the quoted interpreter is prefixed with "& " so it is actually invoked. - C2: Claude's ${CLAUDE_PROJECT_DIR} dispatcher path is now double-quoted ("${CLAUDE_PROJECT_DIR}/.specify/events.py") so the variable still expands (double quotes allow expansion in POSIX shells) but a project path containing spaces no longer word-splits and breaks dispatcher launch. Tests: host target never emits PowerShell quotes; windows target carries the & call operator; Claude dispatcher is double-quoted; updated Copilot generation assertions for the &-prefixed powershell command. Refs: PR github#3704 Copilot review (findings C1, C2) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): opencode TS plugin resolves dispatcher from directory, execFileSync argv, forwards input+output Address three Copilot review findings on the opencode TS plugin: - C8: the dispatcher and interpreter are now resolved per-project at plugin load from the `directory` OpenCode passes to the plugin factory, not process.cwd(). OpenCode may be launched from a parent directory or host another workspace, in which case process.cwd() pointed at the wrong project and every event failed. The resolver prefers a project-local venv interpreter, then falls back to python3. - C9: the dispatcher is launched with execFileSync and an argv array [interpreter, dispatcher, command, event] instead of a shell command string built by interpolating the interpreter/command/event into a template literal. Command/event strings are only validated as non-empty, so quotes or backticks could previously break the generated TypeScript and shell metacharacters could execute outside the dispatcher; an interpreter path with spaces also failed. No shell is involved now. - C7: tool callbacks now forward both `input` and `output` to runEvent (combined into one JSON payload), so pre_tool_use can inspect the tool arguments and post_tool_use can inspect the result — the primary payload for those events. Previously only `input` was forwarded. Tests: plugin resolves dispatcher/interpreter from `directory` (no process.cwd() path.join), uses execFileSync (no shell string), and forwards output to runEvent for both pre/post_tool_use. Refs: PR github#3704 Copilot review (findings C7, C8, C9) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): Qwen ms timeout, Devin root-nested format, Copilot agentStop Address three Copilot review findings on adapter mappings (verified against each agent's published hook documentation): - U1: Qwen Code command hooks measure timeout in milliseconds (default 60000), per the Qwen Code hooks docs. The adapter previously inherited the seconds default, so every generated handler got timeout: 60 (60 ms) and was killed before the dispatcher could start. Declare events_timeout_unit="ms". - U2: Devin's .devin/hooks.v1.json is a root event map ({"PreToolUse": [...]}) with no top-level "hooks" wrapper (the docs state "the hooks object is the entire file"). The adapter reused json-nested, which writes events under a "hooks" key Devin never reads. Add a json-root-nested format with a matching writer (_merge_json_root) and remover (_remove_json_root_entries) that operate on the root event keys, sharing the matcher-grouping, marker, and JSONC-abort behavior of the nested variants. - U3: Copilot CLI supports the canonical per-turn stop lifecycle as native agentStop; add "stop": "agentStop" to the mapping so an extension's stop handler fires for Copilot. Tests: Qwen timeout converts to 60000; Devin events written at the root (no "hooks" wrapper) and teardown preserves user root entries; Copilot stop maps to agentStop. Refs: PR github#3704 Copilot review (findings U1, U2, U3) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): collect events via validated manifest, surface refresh failures Address two Copilot review findings: - R1: collect_extension_events now reads events from a validated ExtensionManifest (whose command refs were canonicalized at install validation, C11) instead of the raw extension.yml YAML. Previously an event command ref like my-ext.boot was normalized to speckit.my-ext.boot during install validation, but the on-disk YAML kept the obsolete name; refresh then emitted it and _find_command_template could not match it, leaving the hook silently inert. Registry-tracked extensions use the validated manifest; on-disk extensions not yet in the registry fall back to the raw YAML (preserving the partial-staged-install scan behavior). - R3: refresh_integration_events now accumulates per-integration failures and raises EventRefreshError at the end (after refreshing the others) so the extension lifecycle commands (add/remove/enable/disable) can't claim an extension was fully deactivated while a stale native hook may still be active. A new _refresh_events_and_warn helper surfaces the aggregated failures as a warning at each call site without aborting the overall command (the extension was already added/removed/enabled/disabled). Tests: event command ref canonicalized via the validated manifest; refresh failure raises EventRefreshError (aggregated) while still preserving the pre-existing config. Refs: PR github#3704 Copilot review (findings R1, R3) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): probe venv for specify_cli before selecting it; python on Windows Address two Copilot review findings on interpreter resolution: - R2: the dispatcher's _find_specify and the opencode TS resolver both selected a project-local venv python and ran `-m specify_cli` without checking that specify_cli is importable there. In a typical project where Spec Kit is installed globally (or via uv tool) but the project has its own unrelated virtualenv, every event invoked that interpreter and failed instead of reaching the PATH `specify` fallback. Both now probe the candidate interpreter (subprocess `import specify_cli` / execFileSync probe) before selecting it, falling through to the fallback when the venv lacks Spec Kit. - S2: the opencode TS PATH fallback was always `python3`, which is commonly unavailable on Windows. It is now `python` on Windows (process.platform === 'win32') and `python3` on POSIX. Tests: the generated dispatcher contains the _has_specify_cli probe and the PATH fallback; the opencode TS plugin probes for specify_cli and uses a platform-appropriate PATH interpreter. Refs: PR github#3704 Copilot review (findings R2, S2) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): serialize opencode TS plugin string literals as JSON Address Copilot review finding S1: command and matcher values come from user/extension YAML but were interpolated into single-quoted TypeScript literals without escaping. A quote, backslash, or backtick in a command or matcher produced invalid generated TypeScript and could inject code into the plugin. _build_opencode_plugin now serializes every interpolated value (command, event name, native hook key, matcher tool names) as a JSON string literal via json.dumps, which produces a valid double-quoted, fully-escaped TS/JS string. Tests: a command and matcher containing quotes/backticks render inside JSON double-quoted literals; the dangerous single-quoted form is absent. Updated the forwards-output test for the new double-quoted literals. Refs: PR github#3704 Copilot review (finding S1) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): thread per-handler timeout through dispatcher, bash launcher for sh on Windows Address two Copilot review findings: - S4: the dispatcher and inner runner both hardcoded timeout=120, so a valid handler configured with a timeout above 120 seconds could never run for its full duration. The resolved per-handler timeout now flows through the chain: _dispatcher_command appends it (in the integration's native unit, plus a small buffer) as a 4th argument; the generated dispatcher reads sys.argv[3] and uses it for its inner subprocess and the `event run` invocation; `event run` accepts a timeout argument and passes it to resolve_and_run_event_command, which uses it for the script subprocess. Defaults to 120s when absent (backward compat with already-deployed dispatchers that don't pass the arg). - S5: for a project configured with the sh script type on Windows, subprocess.run(shell=False) cannot execute a .sh file directly (chmod doesn't change that). The sh variant now prefixes a bash/sh launcher (resolved via shutil.which) on Windows, mirroring the ps branch's pwsh -File handling. Tests: dispatcher reads the timeout arg and uses it; the native command appends the resolved timeout; the sh variant uses a launcher on Windows. Refs: PR github#3704 Copilot review (findings S4, S5) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): delete shared dispatcher when last event integration disables events Address Copilot review finding S3: the empty-resolved-map install path (--events false upgrade, or override disabling events) stripped prior native hooks but left the shared dispatcher behind. Because the new manifest no longer claims it and stale cleanup excludes it (C3), .specify/events.py became permanently orphaned when this was the last event-capable integration — uninstall could not remove it. Extracted the dispatcher refcount cleanup into _cleanup_shared_dispatcher (shared by remove_integration_events and the empty-map install path) and called it from the empty-map path so the dispatcher is deleted when no other installed event-capable integration's manifest references it, while still being retained when another integration does. Tests: an --events false upgrade of the last event integration deletes the dispatcher; with another integration still referencing it, the dispatcher is retained. Refs: PR github#3704 Copilot review (finding S3) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): map user_prompt_submit/stop for Gemini and Tabnine Address two Copilot review findings on adapter mappings: - S6: Gemini exposes BeforeAgent for the per-turn prompt-submit lifecycle point (verified against Gemini CLI's hooks docs — BeforeAgent fires after the user submits a prompt, before planning). The mapping omitted user_prompt_submit, so valid extension handlers were skipped. Added user_prompt_submit -> BeforeAgent. - S7: Tabnine's Gemini-compatible schema also provides BeforeAgent and AfterAgent, but the mapping omitted user_prompt_submit and stop. Added user_prompt_submit -> BeforeAgent and stop -> AfterAgent so those extension events fire instead of being warned about and skipped. Tests: Gemini and Tabnine mappings include BeforeAgent/AfterAgent. Refs: PR github#3704 Copilot review (findings S6, S7) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): correct timeout unit threading through dispatcher and opencode TS Address two Copilot review findings on the per-handler timeout threading added in the prior round (S4): - R2: _dispatcher_command passed _native_timeout(timeout_seconds) as the dispatcher's 4th argument, but the dispatcher interprets that argument as seconds. For Gemini/Qwen/Tabnine (ms adapters), 60 seconds became 60000 seconds (~16h). It now passes the raw seconds (no unit conversion). The +5s buffer moves to the native hook timeout field (_native_timeout(seconds + EVENT_TIMEOUT_BUFFER)) so the agent's outer cap fires after the dispatcher's inner subprocess timeout — letting the inner kill its child cleanly instead of being killed mid-flight (which orphaned the grandchild script process). - S3: the opencode TS runEvent hardcoded timeout: 60000 (60s) and invoked the dispatcher without its timeout argument, so handlers configured above 60s were killed early while the inner runner defaulted to 120s. runEvent now accepts a timeoutSec parameter (seconds); execFileSync uses (timeoutSec + buffer) * 1000 ms and appends String(timeoutSec) to the dispatcher argv, so both layers honor the per-handler timeout. Tests: the dispatcher arg is raw seconds for ms adapters (60, not 60000); the native timeout field carries the buffer (65 for a 60s Claude handler); opencode runEvent threads the per-handler timeout as the 5th argument. Refs: PR github#3704 Copilot review (findings R2, S3) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): skip disabled extensions in _find_command_template and disk fallback Address Copilot review finding S1: _find_command_template resolved event commands without filtering enabled: false — the registry loop used registry.keys() and the raw directory fallback could also rediscover disabled extensions. If native cleanup is skipped (e.g. a JSONC config cannot be parsed), a stale hook would therefore continue executing a disabled extension. Extracted the disabled-ID logic into _disabled_extension_ids (shared with collect_extension_events) and applied it to both the manifest-resolution loop and the on-disk fallback scan in _find_command_template, so a disabled extension's command is never resolved for dispatch. Tests: a disabled extension's command resolves to None via both the manifest loop and the disk-fallback path. Refs: PR github#3704 Copilot review (finding S1) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): delete shared dispatcher regardless of fresh manifest claim Address Copilot review finding S2: _cleanup_shared_dispatcher gated the no-other-references deletion on `dispatcher_rel in manifest.files`. An `integration upgrade --integration-options "--events false"` passes a fresh manifest (created in _migrate_commands) that never recorded the dispatcher, so the condition was false even though the old on-disk manifest owned the file — and stale cleanup explicitly excludes it (C3), leaving .specify/events.py orphaned after the last integration disabled events. The refcount deletion now runs independently of whether the new manifest contains the key; manifest.remove() stays conditional (a no-op when the key is absent). Tests: an upgrade passing a fresh manifest (no dispatcher claim) still deletes the shared dispatcher when no other integration references it. Refs: PR github#3704 Copilot review (finding S2) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): refresh native event config after extension update Address Copilot review finding S4: the _refresh_events_and_warn helper was wired to extension add/remove/enable/disable, but not to extension_update, which replaces the installed extension.yml (remove + install_from_zip). If an update adds, removes, or changes event declarations, native configs remained stale until a manual integration upgrade. extension_update now refreshes once after the update loop finalizes its successful updates (skipped on rollback/failure), mirroring the other lifecycle commands. Refs: PR github#3704 Copilot review (finding S4) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): make the dispatcher self-contained for one-time/temporary installs Address Copilot review finding R1: the dispatcher required a persistent `specify` executable at runtime. The supported one-time flow runs `specify init` through a temporary `uvx` environment that is discarded, so generated hooks later reached the PATH fallback with no `specify` on PATH and every event failed. The generated .specify/events.py is now self-contained: - Preferred path: it imports specify_cli.events.resolve_and_run_event_command when the package is importable (durable pip/pipx/uv-tool install), which handles extension manifests whose file stem differs from the command name and the project's custom script selection, staying in sync with the CLI. - Fallback path: an inline stdlib-only resolver finds the command template, parses its scripts: frontmatter, resolves the project's script variant (reading .specify/init-options.json directly), and runs the script with the correct launcher (pwsh/bash/interpreter), so one-time and temporary installs work without a persistent `specify` executable on PATH. The `event run` CLI command remains available for manual use; the dispatcher no longer depends on it. Tests: the dispatcher delegates to specify_cli when importable and falls back to the inline resolver when it is not; the inline fallback finds the command template and runs its script end-to-end (shadowing specify_cli with an empty package to force the fallback); the preferred path also runs end-to-end. Refs: PR github#3704 Copilot review (finding R1) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): validate safe destination on all removers and teardown unlinks Address Copilot review findings (inline github#1, suppressed github#2, github#3): - Guard all removers (_remove_json_entries, _remove_copilot_entries, _remove_json_root_entries, _remove_opencode_entries, _remove_native_event_hooks), _cleanup_shared_dispatcher, and remove_integration_events with _ensure_safe_destination(dst) before reading, rewriting, or unlinking. - Prevents teardown or removal operations from overwriting or unlinking external files if a config file, plugin path, or .specify directory is replaced with a symlink post-installation. Tests: added unit tests in TestSafeWriteDestination covering JSON config, OpenCode plugin, and TOML teardown symlink rejection. Refs: PR github#3704 Copilot review (findings inline github#1, suppressed github#2, github#3) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): manifest-driven resolution and disabled-extension filter in dispatcher template Address Copilot review finding (suppressed github#1): - In _EVENTS_DISPATCHER_TEMPLATE's _find_command_template, read .specify/extensions/.registry to identify disabled extensions (enabled == false). - Parse provides.commands in each enabled extension's extension.yml to match command_name to its declared file, so commands whose file stem differs from the command name (e.g. speckit.selftest.extension -> commands/selftest.md) resolve correctly when specify_cli is unavailable (one-time uvx installs). - Skip disabled extensions in both manifest-driven and on-disk fallback scans. Refs: PR github#3704 Copilot review (finding suppressed github#1) Assisted-by: opencode (model: glm-5.2, autonomous) * fix(events): positive integer timeout validation and OpenCode multi-handler error aggregation Address Copilot review findings (suppressed github#4, github#6): - In validate_events and _validate_resolved_event, validate that timeout (when present) is a positive integer (isinstance(t, int) and not isinstance(t, bool) and t > 0). Rejects string, boolean, zero, or negative timeouts at manifest and override validation time instead of crashing during setup/refresh. - In _build_opencode_plugin, wrap each runEvent invocation inside _ev() in a try/catch block, collect error messages, and throw an aggregate error at the end if any handler failed. Guarantees that all handlers for an event execute to completion even if an earlier handler throws. Tests: added TestTimeoutValidation testing string, boolean, and zero timeout rejections; updated OpenCode plugin merging tests for try/catch error collection. Refs: PR github#3704 Copilot review (findings suppressed github#4, github#6) Assisted-by: opencode (model: glm-5.2, autonomous)
…he text "None" (github#3798) BundleManifest.from_dict read every required scalar as `str(raw.get(key, "")).strip()`. The `""` default only covers a MISSING key. A key present but null -- exactly how YAML spells an empty field (`author:` with nothing after it) -- yields None, and `str(None)` is the literal string "None". That value is non-empty, so it sailed past the `if not value` required-field checks in structural_errors(). Reproduced on main: bundle.yml with description:/author:/license: left empty -> description='None' author='None' license='None' -> structural_errors() == [] -> specify bundle validate: exit 0, "demo is well-formed and valid." So an empty required field was silently accepted and the bundle shipped the literal text "None" as its author/license/description -- which is what `bundle info` and a catalog entry then display. A null `provides.<kind>[].id` likewise became a component literally named "None". Add a `_text()` helper beside the existing `_parse_str_list` (the file's established "one coercion helper applied at every site" shape) mapping an explicit null to "", and route the required scalars through it. Same silent-acceptance class as the already-merged guards in this function: github#3629 (non-mapping `integration:`) and github#3661 (falsy non-mapping requires/provides). Non-null values are still `str()`-coerced and stripped, and an absent key already produced "" -- so valid manifests are byte-for-byte unaffected. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…sage (github#3800) Both places a user learns the `specify self upgrade --tag` syntax silently drop the `[suffix]` token, because Rich parses the literal square brackets as a markup tag and discards them: rejected tag -> "Invalid --tag: expected vMAJOR.MINOR.PATCH" (constant is "Invalid --tag: expected vMAJOR.MINOR.PATCH[suffix]") --help -> "Pin the target version (vX.Y.Z). Without --tag, ..." So the CLI implies a bare vX.Y.Z is the ONLY accepted form, when v1.0.0-rc1, v0.8.0.dev0 and v0.8.0+build.42 are all valid -- and the shipped docs advertise the suffix in four places (docs/upgrade.md x3, README.md x2). Escape the rejection message at the PRINT site rather than baking `\[` into _INVALID_TAG_MESSAGE: the same constant is raised through typer.BadParameter, which Click renders without Rich, so it must stay plain text. Escape the literal bracket in the option help, which Typer renders through Rich. Same literal-bracket class as the existing precedents in workflows/_commands.py (`\[disabled]`, `\[<type>]`). Static CLI text only -- no validation semantics change and `_validate_tag` is untouched. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…#3832) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github#3799) CommandRegistrar.render_toml_command passes the raw frontmatter `description` straight into `_render_basic_toml_string`, which iterates the value and calls ord() on each character. Frontmatter comes from yaml.safe_load, so description can be any YAML type: description='ok string' -> description = "ok string" description=None -> TypeError: 'NoneType' object is not iterable description=42 -> TypeError: 'int' object is not iterable description=True -> TypeError: 'bool' object is not iterable description=['a','b'] -> description = "ab" <- silently WRONG value This is a format-branch asymmetry: it is the only renderer reached from register_commands' format branches that does not normalise description. render_yaml_command (same class, ~70 lines below) already does exactly `if not isinstance(description, str): description = str(description) if description is not None else ""`, render_markdown_command goes through yaml.dump which handles any type, and TomlIntegration._extract_description returns "" for a non-str. So only extension/preset commands rendered for the two TOML agents were affected. Apply the same coercion the sibling uses. After: None -> "", 42 -> "42", True -> "True", ['a','b'] -> "['a', 'b']", each still valid parseable TOML. String descriptions are untouched. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ithub#3859) The extensions `events` feature changed the "nothing provided" validation error from "Extension must provide at least one command or hook" to "Extension must provide at least one command, hook, or event", but test_empty_provides_and_no_hooks_keeps_its_own_message still asserted the old wording, so it failed on main. Update the regex and also pop `events` from the fixture so the test truly exercises the empty-provides path. Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 189d67d7-2028-4319-a459-b22919d43a3e
…eleted (github#3805) `IntegrationManifest.uninstall()` guards every tracked-file `path.unlink()` with `except OSError: skipped.append(path)`, but the manifest's own `manifest.unlink()` is bare. The manifest is deleted *last*, so an undeletable manifest (read-only file, a directory left at the path, a Windows lock) raises after the tracked files are already gone. The caller loses the `(removed, skipped)` result and never runs its post-uninstall bookkeeping — reassigning the default integration, rewriting/removing `integration.json`, clearing init options — leaving a removed integration still recorded as installed. Report it in `skipped` like any other file we could not remove, mirroring the `path.unlink()` guard above and the same `except OSError: skipped.append(...)` pattern in kimi's legacy-directory cleanup. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…xtension skill re-registration after upgrade (github#3853) * Fix upgrade-overwrites-copilot-skills: pass force=True to extension skill re-registration after upgrade Apply the remediation from the bug assessment on issue github#3849. _register_extension_skills() had a skip guard that refused to overwrite existing SKILL.md files (protecting user customizations). In the upgrade path, setup() regenerates all core-template SKILL.md files first, then calls register_enabled_extensions_for_agent(). The guard then sees those freshly-written core files as 'existing' and skips every extension, leaving only core template content on disk. Fix: add force: bool = False to _register_extension_skills() and thread it through register_enabled_extensions_for_agent() and _register_extensions_for_agent(). In integration_upgrade(), pass force=True so extension content layers on top of the just-regenerated core files. The force flag is off-by-default so plain extension add still protects user-modified skill files. Refs github#3849 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Potential fix for pull request finding 'Unused local variable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * test: add end-to-end regression guard for upgrade-overwrites-copilot-skills (github#3849) The existing regression tests in TestRegisterExtensionSkillsForceFlag exercise the new force parameter at the helper level, so without the fix they fail only with a TypeError (unknown kwarg) rather than on the user-facing behaviour. Add a command-level test that runs 'specify integration upgrade copilot --skills --force' end-to-end and asserts the installed git extension's SKILL.md is restored (with its extension content, not a bare core-template stub) when the skill directory already exists — the exact skill_dir_preexists path the bug depends on. The test fails on pre-fix source (the skill is never recreated) and passes with the fix, so it is a genuine behavioural regression guard rather than an API-surface check. Refs github#3849 Assisted-by: GitHub Copilot (model: claude-opus-4.8, autonomous) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Manfred Riem <15701806+mnriem@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…put (github#3806) `preset catalog add` and `preset catalog remove` interpolate the raw `--name` and URL into `console.print()`, so Rich parses them as markup. Two failure modes: * Silent misreporting — a name like `[bold red]pwned[/]` is printed as `pwned`, so the confirmed name is not the persisted name and a later `remove` with the reported name fails. * Unhandled MarkupError — an unbalanced closing tag raises, and because the crash happens *after* preset-catalogs.yml is written, the user gets a traceback for a catalog that was in fact added. This file already imports `_escape_markup` and escapes name/description/ url in `preset catalog list` (whose invariant `test_catalog_list_escapes_ rich_markup` already pins); `add`/`remove` were the remaining gaps. Only rendering changes: the raw values are still what get persisted and what the duplicate-name comparison uses. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…dary (github#3808) `test_validate_rejects_non_string_condition` contradicts its sibling `test_validate_accepts_string_or_bool_condition` in the same class: a bool *is* a non-string, so the two names disagree about the contract the validator actually implements. Rename to `test_validate_rejects_non_string_non_bool_condition` in all three step classes, matching the validator's own message: "'condition' must be a string or boolean, got <type>". Test names only — no behaviour change, and the parametrized values are untouched. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ithub#3847) * fix(workflows): validate prompt step 'timeout' like the shell step PR github#3768 added a `timeout` to the prompt step and passed it straight into `subprocess.run(timeout=...)`. Neither `validate()` nor `execute()` checks it, so a bad value from a user-authored `workflow.yml` escapes as a raw exception: steps: - id: first type: shell run: echo side-effect - id: ask type: prompt prompt: do it timeout: abc $ specify workflow run wf.yml > [first] shell ... Workflow failed: unsupported operand type(s) for +: 'float' and 'str' The engine re-raises anything a step throws, so this takes down the whole run — after `first` has already run its side effect — with a message that names neither the step nor the field. `timeout: .nan` raises `ValueError: cannot convert float NaN to integer` the same way, and a non-positive `timeout` (`0`, `-5`) makes `subprocess.run` report an immediate TimeoutExpired for a command that never got the time to run. `timeout: true` silently becomes a 1-second limit, since bool is an int subclass. The sibling shell step already rejects exactly these values via a `_timeout_error()` helper shared by `execute()` and `validate()`, so the same workflow failed validation cleanly as a shell step and crashed as a prompt one. Mirrored that helper onto PromptStep: `validate()` reports the contract error, and `execute()` re-checks it so an unvalidated run fails just that step instead of aborting. Now: Workflow validation failed: - Prompt step 'ask': 'timeout' must be a positive number of seconds, got 'abc'. caught before the first step runs. Positive int/float timeouts and an absent `timeout` are unaffected. Regression tests in `TestPromptStep` mirror the shell step's: validate rejects "30"/True/inf/nan/0/-5/list/None, validate accepts 300/5/0.5 and an absent field, and execute fails cleanly with `subprocess.run` patched to assert it is never reached. With the source fix reverted, all 9 rejection tests fail. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-by: Claude Code (model: claude-opus-5, under direct human supervision) * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * test(workflows): cover the huge-int timeout OverflowError guard The autofix commit wrapped the prompt step's `_timeout_error()` check in `try/except OverflowError` but added no test, so nothing pins the behaviour it introduced. `math.isfinite(10**400)` raises `OverflowError: int too large to convert to float` — the value is an `int`, is `> 0`, and is not a `bool`, so it clears every other clause of the guard and reaches `isfinite()`. Without the `except`, validating ```yaml - id: ask type: prompt prompt: do it timeout: 1000...0 # 400 digits ``` raises that `OverflowError` out of `validate()`/`execute()` — exactly the uncaught-crash failure mode this guard was added to prevent. The same value raises `OverflowError` from `subprocess.run(timeout=...)`. Add `10**400` to both parametrized rejection lists (`validate()` and the `execute()` fails-cleanly loop). Test-the-test: reverting the `try/except` fails both new cases with `OverflowError` and leaves the rest passing. Assisted-by: Claude Opus 5 (model: claude-opus-5, autonomous) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Add `intent` extension submitted by @SuhaibAslam to: - extensions/catalog.community.json (inserted alphabetically between intake and issue) - docs/community/extensions.md community extensions table This revision limits the catalog change to the intent addition and the top-level updated_at bump only, reverting the unrelated re-serialization (entry reordering, \u2014 Unicode escaping, tool-array reformatting) that a reviewer flagged. Closes github#3854 cc @SuhaibAslam Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Manfred Riem <15701806+mnriem@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…Error (github#3865) PR github#3847 hardened the prompt step's `timeout` guard against a huge-int value, but its twin in the shell step — the step the prompt one was mirrored from — still has the hole. `math.isfinite(10**400)` raises `OverflowError: int too large to convert to float`. A 400-digit YAML scalar is an `int` and is not a `bool`, so it clears every clause before `isfinite()` and raises there, escaping `_timeout_error()` as exactly the uncaught crash that helper exists to prevent: steps: - id: qa type: shell run: echo hi timeout: 1000...0 # 400 digits $ specify workflow run wf.yml Traceback (most recent call last): ... File "src/specify_cli/workflows/engine.py", line 361, in _validate_steps step_errors = step_impl.validate(step_config) File "src/specify_cli/workflows/steps/shell/__init__.py", line 127 or not math.isfinite(timeout) OverflowError: int too large to convert to float `workflow_run` calls `engine.validate()` before executing any step, so the OverflowError propagates out of `validate_workflow` and kills the command with a bare traceback that names neither the step nor the field, instead of the "Workflow validation failed" report. `execute()` shares the same helper, so an unvalidated run raises there too — and the engine re-raises anything a step throws, aborting the whole workflow after earlier steps have already run their side effects. The value is genuinely invalid rather than merely unrepresentable in the check: `subprocess.run(timeout=10**400)` raises the same OverflowError. Unlike the prompt step, the shell step checks `isfinite()` *before* `timeout <= 0`, so a negative huge int (`-(10**400)`) crashes as well rather than being caught by the sign check. Wrapped the condition in `try/except OverflowError` and treated the value as invalid, mirroring the prompt step's guard so both steps reject the same values with the same message. Now: Workflow validation failed: - Shell step 'qa': 'timeout' must be a positive number of seconds, got 1000...0. Valid int/float timeouts, non-finite floats, bools, strings and non-positive values are unaffected — the existing clauses are unchanged. Regression tests in `TestShellStep`: `validate()` rejects both signs of the huge int, `validate_workflow()` reports it end to end (pinning the path the CLI actually takes, not just the helper), and `execute()` fails only that step with `subprocess.run` patched to assert it is never reached. Test-the-test: reverting the source change fails all three with `OverflowError` and leaves the rest of `TestShellStep` passing. Assisted-by: Claude Code (model: claude-opus-5, under direct human supervision) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
* Add yolo to community workflow catalog - Workflow ID: yolo - Version: 0.1.0 - Author: clintcparker - Description: Runs specify → plan → tasks → implement without review gates * Update speckit_version requirement to 0.8.12
* chore: bump version to 0.15.0 * chore: begin 0.15.1.dev0 development --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Relative image paths do not render on the PyPI project page. Convert the remaining logo and video-header image references to absolute raw.githubusercontent.com URLs so they display correctly on https://pypi.org/project/specify-cli/ while continuing to render on GitHub. Addresses the rendering gap noted in github#2908. Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8a8563a-328e-43a4-8eb7-ff381f912161
) * feat: bind gate verdict to workflow input via verdict_input Add an optional `verdict_input` field to gate steps that lets an external system supply a verdict through a declared workflow input instead of an interactive TTY prompt. When the referenced input carries a non-empty string value that matches one of the gate's `options` (case-insensitive), the gate auto-decides, records the matched spelling in `output.choice`, and applies the existing `on_reject` / abort / skip / retry semantics. If the value is present but does not match an option, or is a non-string, the gate fails immediately with a clear error message. When the input is absent, null, or empty, the gate falls back to today's TTY-prompt-or-pause behaviour unchanged. The engine now persists `result.error` alongside each step's status and output so that failed-step error messages survive across runs. The CLI (`workflow run` and `workflow resume`) surfaces these persisted errors after a failed or aborted run. `validate_workflow` cross-references `verdict_input` against the workflow's declared inputs block and reports an error for undeclared names, consistent with the existing `wait_for` id cross-check. Closes discussion: github#3717 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Fix workflow JSON error payloads Include persisted step errors in _workflow_run_payload so workflow run/resume/status --json all surface failure reasons consistently. Add JSON-path tests for failed and successful runs. Assisted-by: GitHub Copilot (model: gpt-5.3-codex, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix(workflows): reject verdict inputs in fan-out Fan-out items share workflow inputs and cannot safely consume a bound gate verdict. Reject verdict_input bindings during validation and at runtime while preserving unbound gates. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: update workflow command handling Assisted-by: GitHub Copilot (model: gpt-5.3-codex, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Markus <markus@example.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add contextforge-mcp extension submitted by @capatinore to: - extensions/catalog.community.json (alphabetical order) - docs/community/extensions.md community extensions table Closes github#3456 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(bundler): reject non-string manifest list members Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs(bundler): clarify string list validation Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…github#4143) `SwitchStep.execute` matched with `str(value)` and no strip. The values a switch dispatches on are overwhelmingly captured command output, and `ShellStep` stores `proc.stdout` verbatim, so `run: echo approve` resolves to "approve\n" — which matches no `approve:` case: stdout stored : 'approve\n' matched_case : '__default__' <-- silently wrong next steps : ['fallback'] The switch falls through to `default:` (or dispatches nothing at all) while still reporting COMPLETED. A workflow author cannot fix it themselves: the registered filters are default/join/map/contains/from_json — there is no `trim`. spec-kit already treats exactly this as a bug wherever else it matches a resolved string against declared literals — `evaluate_condition` strips for this same shell-newline reason, and `InitStep._resolve_bool` does `resolved.strip().lower()`. Switch case keys are such literals, and this was the only site not stripping. `expression_value` still reports the raw value, so nothing downstream loses information, and a genuine mismatch ("approve-later") still falls through. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
`SwitchStep.validate` requires `expression` and type-checks `cases`, but
never checks that `cases` is PRESENT. It is the only control-flow step whose
branch payload is optional:
if -> requires 'then'
fan-out -> requires 'items' and 'step'
fan-in -> requires a non-empty 'wait_for'
gate -> requires 'message'
switch -> cases optional
So a switch whose branch table is absent or mistyped — `case:` for `cases:`
is the obvious slip — passes validation with zero errors:
if missing then : ["If step 'x' is missing 'then' field."]
fanout missing all: ["Fan-out step 'y' is missing 'items' field.", ...]
switch typo case: : []
switch no cases : []
and then at run time reports COMPLETED with
`matched_case: "__default__"` — a default it does not even declare — having
dispatched nothing, so the whole run "succeeds". That is the "silent empty
result + COMPLETED" wiring bug the fan-in guard exists to prevent.
An explicitly declared but empty `cases: {}` is still a declaration and
stays valid, pinned by a test.
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Update specassay-check extension submitted by @rdryfoos to: - extensions/catalog.community.json (version, download_url, description, provides.commands) - docs/community/extensions.md community extensions table Closes github#4252 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* chore(deps): bump astral-sh/setup-uv from 9.0.0 to 10.0.1 Bumps [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) from 9.0.0 to 10.0.1. - [Release notes](https://github.com/astral-sh/setup-uv/releases) - [Commits](astral-sh/setup-uv@c771a70...20cfd1b) --- updated-dependencies: - dependency-name: astral-sh/setup-uv dependency-version: 10.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * fix(workflows): align setup-uv generated sources Update the agentic workflow sources, action cache, generated metadata, and regression expectation for setup-uv v10.0.1. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 394a7929-b17c-470f-a3e6-b5863f9c9d40 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Manfred Riem <15701806+mnriem@users.noreply.github.com> Copilot-Session: 394a7929-b17c-470f-a3e6-b5863f9c9d40
* docs: add workflow quickstarts Add concise setup and command recipes for SDD, structured bug fixing, and standalone idea assessment. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: af05cfd0-746d-4292-9380-0a785a991cba * docs: clarify quickstart release tags Tell readers to replace the placeholder in every standalone quickstart with the latest tagged release. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: af05cfd0-746d-4292-9380-0a785a991cba --------- Copilot-Session: af05cfd0-746d-4292-9380-0a785a991cba
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6b3d69-9459-4a26-a2f6-4d946e368c81
* docs: add project history page Document Spec Kit's stewardship periods, major technical milestones, community catalogs, and evolution from core SDD processes to a composable toolkit. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 46d71f0b-59fc-4bdb-a57e-620210197597 * docs: clarify stewardship wording Use the possessive form to make clear that the focus belongs to the maintainer team. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 46d71f0b-59fc-4bdb-a57e-620210197597 --------- Copilot-Session: 46d71f0b-59fc-4bdb-a57e-620210197597
Add a safe brownfield onboarding path and connect it to the docs homepage, quick start, navigation, and spec maintenance guidance. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 663b4e07-d79f-4bd1-aa86-8aeea21a2643
Use the README logo for the DocFX navbar, favicon, and landing hero, and add Upgrade to the balanced Explore the docs grid. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 78ca683f-2995-44eb-a2fa-f7600c18bbd9
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f0ad8f8-ea22-44ca-86c7-a485c888ec91
* chore: bump version to 1.0.1 * chore: begin 1.0.2.dev0 development --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Update reconcile extension submitted by @stn1slv: - extensions/catalog.community.json (version, download_url, requires.speckit_version, provides.hooks, updated_at) - docs/community/extensions.md community extensions table (no changes needed) Closes github#4279 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update archive extension submitted by @stn1slv: - extensions/catalog.community.json (version, download_url, requires.speckit_version, updated_at) - docs/community/extensions.md community extensions table Closes github#4278 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update specassay preset submitted by @rdryfoos: - presets/catalog.community.json (version, download_url, updated_at) Closes github#4253 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the specassay community bundle catalog entry from v0.3.4 to v0.4.12. - Updated version: 0.3.4 → 0.4.12 - Updated download_url to v0.4.12 release asset - Updated updated_at timestamp to 2026-08-21 Validation results: - Bundle ID 'specassay' matches naming convention - Version 0.4.12 is a valid semver X.Y.Z and higher than existing 0.3.4 - Repository https://github.com/rdryfoos/specassay confirmed: bundle.yml, README.md, LICENSE present - bundle.yml fields match submission (id, name, version, role, author, license, speckit_version, provides) - Release v0.4.12 confirmed with specassay-0.4.12.zip asset attached - Download URL matches HTTPS GitHub release asset pattern - Catalog entry validated: all required fields present, verified=false, 5 tags - Required component catalogs (extensions + presets) documented in README and tested - All checklists checked; testing details and example usage are complete Closes github#4255 cc @rdryfoos Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update parallel-autonomous-run-governance preset submitted by @hindermath: - presets/catalog.community.json (version, download_url, documentation, provides.templates, tags, description, updated_at) - docs/community/presets.md community presets table Closes github#4237 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Update BDD extension to v1.0.3 Update bdd extension submitted by @RSginer: - extensions/catalog.community.json (version, download_url, homepage, documentation, name, updated_at) - docs/community/extensions.md community extensions table Closes github#4277 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs(extensions.md): update bdd extension table row order (github#4308) Update the extensions table catalog to folow sorting rules --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rubén Soler <r.solerginer@gmail.com>
Update grill extension submitted by @yoshi1220: - extensions/catalog.community.json (version, download_url, description, commands count) - docs/community/extensions.md community extensions table Closes github#4315 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add taco extension submitted by @Arcadia822 to: - extensions/catalog.community.json (alphabetical order) - docs/community/extensions.md community extensions table Closes github#4309 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ithub#4326) * fix(events): stop `event run` crashing on every piped stdin payload `event_run` (src/specify_cli/commands/event.py) capped its stdin read at 1 MiB to prevent a DoS (github#3857), but the truncation check reads a `.eof` attribute that does not exist on any Python file-like object, including `sys.stdin` (`hasattr(sys.stdin, "eof")` is False). Every piped-stdin invocation raised `AttributeError: '...' object has no attribute 'eof'` instead of running — piped stdin is the command's documented primary use case (a native hook feeds it a JSON payload this way), and `isatty()` is False whenever stdin isn't an interactive terminal, so this fired on essentially every real invocation, not just oversized ones. Even the intended oversized-payload branch was broken a second way: `typer.Exit(code=1, message=...)` — `typer.Exit.__init__` only accepts `code`, not `message` — so that path raised `TypeError` instead of the documented clean error. Fix: detect truncation the standard way (read one more byte once the cap is hit; a non-empty result means more data was waiting beyond it), and report the oversized-payload error via `typer.echo(..., err=True)` before `raise typer.Exit(code=1)`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW9fAYsCBCAgdKWovtSyqt * fix(events): enforce stdin cap in bytes and fix TTY-fallback test gap Address Copilot review feedback on PR github#4326: - sys.stdin is a text stream, so reading MAX_STDIN_BYTES counted Unicode characters, not encoded bytes. A multibyte payload (e.g. ~300k emoji, ~1.14 MiB in UTF-8) could slip past the 1 MiB DoS guard. Read from sys.stdin.buffer instead so the cap counts real bytes, then decode. - The TTY-fallback test invoked via CliRunner, which always supplies a non-TTY stream even without input=, so it never exercised the `"{}"` fallback. Split it into an empty-pipe test (CliRunner) and a real TTY test that calls event_run directly with a mocked isatty()=True stdin. - Added a regression test proving the byte-vs-character cap distinction. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PJHJ2dHP2RVCNncHqN8Qm9 * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * test(events): cover invalid-UTF-8 stdin negative path Reviewer noted the new UnicodeDecodeError guard in event_run had no test proving it exits cleanly instead of leaking a raw UnicodeDecodeError. Add a case piping invalid UTF-8 (b"\xff\xfe") and assert exit code 1, the "must be valid UTF-8" message, and that the handler is never invoked. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M9aV6DhKNL7k3HreTczcb1 --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Add codebase-memory-context preset submitted by @philo-x to: - presets/catalog.community.json (alphabetical order) - docs/community/presets.md community presets table Closes github#4327 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates workflow run discovery to tolerate state files removed during reading.
Changes:
- Replaces the
exists()check with exception-based handling. - Skips missing, malformed, or unreadable state files.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/workflows/engine.py |
Makes run-state loading resilient to file races. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
|
Please address Copilot feedback and resolve the merge conflicts with |
- Remove exists() guard to eliminate TOCTOU race where state.json is deleted between exists() and open() - Wrap open/load in try/except FileNotFoundError to skip missing files - Add UnicodeError to handled exceptions (invalid UTF-8 in state.json) - Add tests for missing state.json and invalid UTF-8 state.json Fixes github#3838
Resolve conflict: keep UnicodeError handling and isinstance validation from Copilot review feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle TOCTOU race where
state.jsonis deleted betweenexists()check andopen().Changes
engine.py: Removedexists()guard, wrapped open/load in try/except to skip missing/corrupt state files