Skip to content

Reset performance metrics on FORCE_REMOUNT (same story ID) #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Reset performance metrics on FORCE_REMOUNT (same story ID) #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26df7ec
Initial plan
Copilot Mar 7, 2026
d04c3b0
feat: reset metrics and create new core on FORCE_REMOUNT
Copilot Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 25 additions & 62 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 31 additions & 0 deletions ...orybook-addon-performance-panel/__tests__/performance-decorator-universal.browser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,37 @@
expect(metrics.reactMountCount).toBe(0)
})

it('creates a new core when force remount is triggered (same story ID)', () => {
const ctx = makeCtx({id: 'story-a'} as Partial<StoryContext>)

withPerformanceMonitor(vi.fn(() => ''), ctx)

Check failure on line 231 in packages/storybook-addon-performance-panel/__tests__/performance-decorator-universal.browser.test.ts

View workflow job for this annotation

GitHub Actions / Lint 

Replace `vi.fn(()·=>·''),·ctx` with `⏎······vi.fn(()·=>·''),⏎······ctx,⏎····`
const first = getActiveCore()

// Simulate force remount — same ID but forceRemount flag
const remountCtx = makeCtx({id: 'story-a', forceRemount: true} as Partial<StoryContext>)
withPerformanceMonitor(vi.fn(() => ''), remountCtx)

Check failure on line 236 in packages/storybook-addon-performance-panel/__tests__/performance-decorator-universal.browser.test.ts

View workflow job for this annotation

GitHub Actions / Lint 

Replace `vi.fn(()·=>·''),·remountCtx` with `⏎······vi.fn(()·=>·''),⏎······remountCtx,⏎····`
const second = getActiveCore()

expect(second).not.toBe(first)
})

it('cleans up channel listeners when core is replaced by force remount', () => {
withPerformanceMonitor(
vi.fn(() => ''),
makeCtx({id: 'story-a'} as Partial<StoryContext>),
)

// Force remount replaces the core, which should stop the old one and call channel.off
withPerformanceMonitor(
vi.fn(() => ''),
makeCtx({id: 'story-a', forceRemount: true} as Partial<StoryContext>),
)

expect(mockChannel.off).toHaveBeenCalledWith(PERF_EVENTS.REQUEST_METRICS, expect.any(Function))
expect(mockChannel.off).toHaveBeenCalledWith(PERF_EVENTS.RESET, expect.any(Function))
expect(mockChannel.off).toHaveBeenCalledWith(PERF_EVENTS.INSPECT_ELEMENT, expect.any(Function))
})

it('cleans up channel listeners when core is replaced', () => {
withPerformanceMonitor(
vi.fn(() => ''),
Expand Down
Loading
Loading