Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates TanStack router/start dependencies for the @github-ui/website workspace and adds an npm overrides entry at the repo root to force h3/h3-v2 to 2.0.1-rc.20, with corresponding package-lock.json updates.
Changes:
- Bump
@tanstack/react-routerand@tanstack/react-startversions inpackages/website. - Add root-level npm
overridesto pinh3and theh3-v2alias to2.0.1-rc.20. - Refresh
package-lock.jsonto reflect the new dependency/override resolution.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/website/package.json |
Updates TanStack versions used by the website workspace. |
package.json |
Introduces npm overrides to force a specific h3 / h3-v2 resolution. |
package-lock.json |
Captures the resulting dependency tree/hoisting changes from the updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "node": ">=22" | ||
| }, | ||
| "overrides": { | ||
| "h3": "2.0.1-rc.20", |
There was a problem hiding this comment.
The new repo-wide override for "h3" appears to be unused: the lockfile contains only the aliased "h3-v2" package (installed into node_modules/h3-v2) and no node_modules/h3 entry. If nothing in the dependency tree depends on the package name "h3" directly, consider removing the "h3" override and keeping only the "h3-v2" alias override to reduce override surface area and future surprise upgrades when a direct "h3" dependency is introduced.
| "h3": "2.0.1-rc.20", |
| }, | ||
| "overrides": { | ||
| "h3": "2.0.1-rc.20", | ||
| "h3-v2": "npm:h3@2.0.1-rc.20" |
There was a problem hiding this comment.
these were pinned in ts/react-start, so we have to override pin them
No description provided.