Skip to content

feat: add pagination support when fetching repository environments #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sylfwood wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add pagination support when fetching repository environments #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/treeViews/settings/environmentsNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as vscode from "vscode";
import {GitHubRepoContext} from "../../git/repository";
import {EnvironmentNode} from "./environmentNode";
import {Environment} from "../../model";

export class EnvironmentsNode extends vscode.TreeItem {
constructor(public readonly gitHubRepoContext: GitHubRepoContext) {
Expand All @@ -10,12 +11,16 @@ export class EnvironmentsNode extends vscode.TreeItem {
}

async getEnvironments(): Promise<EnvironmentNode[]> {
const result = await this.gitHubRepoContext.client.repos.getAllEnvironments({
const opts = this.gitHubRepoContext.client.repos.getAllEnvironments.endpoint.merge({
owner: this.gitHubRepoContext.owner,
repo: this.gitHubRepoContext.name
repo: this.gitHubRepoContext.name,
per_page: 100
});

const data = result.data.environments || [];
// retrieve all environments
const result = await this.gitHubRepoContext.client.paginate<Environment>(opts);

const data = result || [];
return data.map(e => new EnvironmentNode(this.gitHubRepoContext, e));
}
}