Repository navigation
fix(app): suggest channel members after @ - #583
Merged
Merged
Conversation
iamnbutler
force-pushed
the
fix-mentions
branch
from
October 22, 2026 15:15
25ed11f to
43412d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composer's @ suggestions now include people, not just
ace: people present in the channel, message authors, and the team roster (Settings → Team → People), by GitHub login. Picking one inserts a plain mention; it doesn't invoke anything or notify anyone. Names with no GitHub login, and agents from other channels (agent@…), are left out. A teammate without agent access still gets people, just notace.The Dashboard composer now passes an
ace-only mentions list, so an unknown@wordstays text instead of becoming a chip.Map: ^485, ^486 (ace-map).
Smoke-tested on a loopback host built from this lane: in a channel with a seeded
ace-demo-riveramessage,@listedaceandace-demo-rivera. Picking it gave a chip, and Chat mode sentthanks @ace-demo-riverawith no run.@nobodystayed text. On the Dashboard,@Add a note @ace okgave only theacechip.Built in Ace
No: Claude Code (the ace2-90 map/fix-train session) wrote and smoke-tested this through a headless host and Playwright, run alongside other sessions. See #5.