Repository navigation
feat(app): notify @mentions of you, and the ones that arrived while you were away - #590
Merged
Merged
Conversation
…ou were away A new mention of you glows the window when it's focused on another channel and sends a desktop notification otherwise. Mentions found within ten seconds of Ace opening or a host reconnecting arrived while you were away and notify once as a summary. The count each channel had when you were last told is kept per host and profile, so reloads and reconnects never repeat a notice. Why: apps/app/src/attention.ts#function useAttention | mention counts are ignored until the person's GitHub login loads; with no names every count reads zero, and recording that would re-notify old mentions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-train task "Notify @mentions, including ones missed while away", building on #577's per-person mention counts.
attention.ts.called) is kept per host and profile besidetold, so reloads and reconnects never repeat a notice. Counts are ignored until your GitHub login loads, since with no names every count reads zero and recording that would re-notify old mentions (found while smoking).Smoked against a loopback host from this lane with a persistent browser profile and temporary console logs beside each notice (removed before commit): a live mention in another channel pulsed; one in the open channel did nothing; three mentions posted while the app was closed gave one summary and nothing on reload; two posted while the host was stopped gave one summary on reconnect, and a mention 15s later pulsed live. In this lane's Ace-dev build, a live mention while the window wasn't focused raised macOS's first "Ace-dev Notifications" permission prompt, so the desktop notify call fires; I left the system prompt for a person to answer, so I didn't see the banner itself.
Built in Ace
No. Built by Claude Code as a fix-train worker outside Ace, driving a loopback Ace host with Playwright and this lane's Ace-dev build for smoke tests; the fix train runs headless agents in parallel, which Ace doesn't orchestrate yet. See #5.