Skip to content

fix(app): hide Issues and Pull requests when a project has no GitHub repository - #591

Merged
iamnbutler merged 2 commits into
mainfrom
fix-gh-repo
Oct 22, 2026
Merged

iamnbutler merged 2 commits into
mainfrom
fix-gh-repo

Conversation

@iamnbutler

Copy link
Copy Markdown
Contributor

Hides the Issues and Pull requests rail tabs, their ⌘3/⌘4 shortcuts and menu actions, and their palette commands when the current project has no GitHub repository. That covers no GitHub remote, and a remote that GitHub can't find for this host's gh account. gh pr list --search returns [] for a missing repository, so the app used to say "No open pull requests". Now project-repo asks gh api repos/<repo>, and a 404 answers null. Other gh failures, such as no gh or signed out, still show the tabs so the lists can explain the problem. A window saved on Issues or PRs opens Channels for such a project.

The asking host runs the check with its own gh account, so a teammate's host only names the remote.

Map: ^726 (Browse a project's issues), ^736 (Browse a project's pull requests).

Smoke: isolated loopback host on :4733 with three projects: no remote, iamnbutler/nonexistent-xyz-123, and githubnext/ace. Driven with headless Playwright. The first two projects show only Dashboard and Channels in the rail, no palette entry, and ⌘4 stays on the channel. The githubnext/ace project shows both tabs, and ⌘4 opens Pull requests for githubnext/ace.

Built in Ace

No. Built by a Claude Code fix-train worker outside Ace, running a lane in the terminal and a headless Playwright smoke. See dogfooding #5.

…repository

Why: apps/host/src/github.ts#function found | gh pr list --search returns [] for a repository GitHub can't find, so only gh api's 404 can tell an empty list from a missing repository
@iamnbutler
iamnbutler merged commit 13218e7 into main Oct 22, 2026
1 check passed
@iamnbutler
iamnbutler deleted the fix-gh-repo branch October 22, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant