Repository navigation
fix(ui): key checks by name and URL so shared check URLs don't collide - #593
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub can list several checks under one URL. On honojs/hono#5535, codecov/patch and codecov/project both link to
app.codecov.io/gh/honojs/hono/pull/5535. The details sidebar's checks list used the URL as the React key, so React logged a duplicate-key warning. The failed-checks notice in the chat had the same problem. Both now key each check by its name and URL.Map: ^690 (Read a channel's work in the details sidebar).
Smoke: isolated loopback host on :4733 serving a development build of the app. The project's remote is honojs/hono, and its branch
feat/wildcard-paramis the head of #5535. With headless Playwright, I opened the channel's details sidebar, which shows both codecov rows. The old code logged React's duplicate-key warning 3 times; with this change it logged none.Built in Ace
No. Built by a Claude Code fix-train worker outside Ace, running a lane in the terminal and a headless Playwright smoke. See dogfooding #5.