Repository navigation
fix(app): wait for this host's name and projects before showing a project, and for GitHub before Issues and PRs - #639
Merged
Merged
Conversation
…ject, and for GitHub before Issues and PRs Why: apps/app/src/app.tsx#function App | the project list is built only once hello names this host and its projects frame arrives; earlier, its own channels read as a teammate's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the app loaded, it built its project list before
hellonamed this host, so this host's own project read as a teammate's ("sandbox · H72Q5YQ4CG", "isn't on this host yet", the channel opened as remote), and it treated a GitHub lookup still in flight as "has GitHub", so Issues and PRs showed and then vanished in a local project.projectsis undefined until the host's first projects frame, and the app builds projects only once it has both that and this host's name.Part of #617 (the loading flash; the Dashboard vs All Projects part is left for its own fix). Map: ^601, ^602, ^611.
Smoke: loopback source host with its own
ACE_HOME, a local git project and a GitHub-remote project, headless Chromium recording every DOM mutation across reloads. On origin/main every reload briefly showed#issues/#prs, "sandbox · H72Q5YQ4CG" and "sandbox isn't on this host yet…"; with this change none appeared on Dashboard, Channels, or an open channel. The GitHub project still shows Issues and PRs after load, and reloading on Issues stays on Issues.Built in Ace
No: made from Claude Code (a fix-train worker), with a headless Chromium to watch the first second of each reload. Dogfooding gap tracked in #5.