Skip to content

fix(host): match a channel's pull request only among the repository's own branches #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamnbutler merged 3 commits into from
Oct 22, 2026
Merged

fix(host): match a channel's pull request only among the repository's own branches #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5db43c3
fix(host): match a channel's pull request only among the repository's…
iamnbutler Oct 22, 2026
f32f04e
chore: record lane note for pull request matching
iamnbutler Oct 22, 2026
7f87faf
lane: sync fix-pr-branch memory
iamnbutler Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...s/host/src/github.ts/01M5JMZZF995AGBW0T463TMG57-gh-head-matches-a-branch-nam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
id: 01M5JMZZF995AGBW0T463TMG57
anchor: function pull
created: 2026-10-22T20:31:43Z
norm: '1'
sig: 86063795bd4c903a
body_hash: 6bb86a7719dc73dc
raw_hash: e870bcc2d71cf57a
lines: 424-456
---

gh --head matches a branch name in any fork; only same-repository pull requests are a channel's
14 changes: 10 additions & 4 deletions apps/host/src/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,15 +416,20 @@ const REVIEWS: Record<string, GithubPull["review"]> = {
REVIEW_REQUIRED: "required",
};

/** The newest pull request whose head is `branch`, or null when there is none. */
/**
* The newest pull request from `branch` in the repository itself, or null when there is none.
* `--head` matches the branch name in any fork, and strangers open pull requests from their forks'
* `master` or `main`, so pull requests from other repositories never count as the channel's.
*/
export async function pull(repo: string, branch: string): Promise<GithubPull | null> {
if (!branch || branch.startsWith("-")) throw new Error("Invalid branch name");
const [value] = await gh<
const found = await gh<
(Item & {
isDraft: boolean;
statusCheckRollup: Check[];
headRefOid: string;
reviewDecision: string;
isCrossRepository: boolean;
})[]
>([
"pr",
Expand All @@ -435,10 +440,11 @@ export async function pull(repo: string, branch: string): Promise<GithubPull | n
"--state",
"all",
"--limit",
"1",
"30",
"--json",
`${FIELDS},isDraft,statusCheckRollup,headRefOid,reviewDecision`,
`${FIELDS},isDraft,statusCheckRollup,headRefOid,reviewDecision,isCrossRepository`,
]);
const value = found.find((candidate) => !candidate.isCrossRepository);
if (!value) return null;
const review = REVIEWS[value.reviewDecision];
return {
Expand Down