Repository navigation
feat(app): mark where unread messages start and highlight mentions of you - #645
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a channel with new messages now shows where they start, and messages that mention you stand out.
@ace/ui) takesunread(the first unseen message's id) andmentioned(ids to highlight);compileinserts anewitem that's laid out like a day divider.Unread counts across a reload already held with a persistent browser profile, as #602 suspected; no change there.
Part of #602 (the divider and the highlight; showing each grouped message's own time is not in this PR). Map: ^903, ^486.
Smoke: loopback source host with its own
ACE_HOME, headless Chromium with a persistent profile. I opened#unread(two of my messages), switched away, posted two messages asrivera(host restarted withACE_USER=rivera), one saying@iamnbutler can you look at the build?, then went back as myself. The row read "1 direct mention" before and after a reload; opening it showed the New divider between my messages and rivera's, and only the mention bubble tinted with the accent bar. Opening it again later showed no divider.Built in Ace
No: made from Claude Code (a fix-train worker), with a headless Chromium for the smoke test. Dogfooding gap tracked in #5.