Repository navigation
fix(app): say a project still has channels before offering to remove it - #647
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove project used to confirm with the empty-project wording and then fail with "This project still has a channel… Delete it first." The app now counts this host's channels in the project (archived ones too, as the host does) before asking:
Part of #616 (the up-front channel check; the picker's ✕ placement is not in this PR). Map: ^347.
Smoke: loopback source host with its own
ACE_HOME, two opened folders (busywith one channel,emptywith none), headless Chromium. Channels ⋯ → Remove project… onbusyshowed "busy still has a channel / It has a channel, counting archived ones. Archive it from its ⋯ menu, delete it from the Archived group, then remove the project. / OK". Onemptyit showed the usual confirmation, and Remove project took it out ofprojects.json.Built in Ace
No: made from Claude Code (a fix-train worker), with a headless Chromium for the smoke test. Dogfooding gap tracked in #5.