Repository navigation
fix(app): keep a waiting question marked until the host hears its answer, on every browser - #679
Merged
Merged
Conversation
…wer, on every browser The channel publishes an answered run state when a question's wait ends with the run still going, and the app reads a pending question from that host state instead of from when this browser profile first visited or last opened the channel. Why: apps/app/src/attention.ts#function pending | a question is pending from the host's ran outcome alone (question until answered/done/failed/stopped), never from this profile's since or seen Why: packages/channel/src/questions.ts#class Questions | onAsk hears answered when the tool's wait resolves (answer, skip or a queued message), never on abort, which the run's end already publishes
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A run waiting on a question now keeps its raised hand (sidebar, Dashboard channel rows, palette's Needs you) until it is answered, not until the channel is opened, and a new browser or phone shows questions that were already waiting.
packages/channel: the question tool'sonAskalso fires when its wait ends with the run still going (answer, skip, or a queued message instead), and the channel publishes that as a newRunEndoutcome,answered. An aborted wait publishes nothing extra; the run's end already does.apps/app/src/attention.ts: a pending question comes from the host'sranalone, ignoring this profile'ssinceandseen. Notifications still skip a question that predates the profile or was seen while it waited, so a new browser lists it without notifying.docs/architecture.mdupdated.Map: ^614 (See which runs need you), ^387 (See a channel that needs you), ^577 (See Needs you on the Dashboard).
Smoke test, run against an isolated
bun ace serve --loopbackwith a realopenai/gpt-5.4-minirun and fresh headless Chromium profiles:ace answer, the host'sranreadansweredwhile the run was still busy (sleep 40), and the Dashboard showed no hand. When the run ended,ranreaddone.Built in Ace
No. A Claude Code fix-train worker made this outside Ace: it edited in a lane, ran checks in a terminal, and smoke-tested with headless Playwright against an isolated host. The fix train runs agents in parallel from one board, which Ace doesn't drive yet. #5