Repository navigation
fix: update team state live after joining or leaving the directory - #680
Merged
Merged
Conversation
The host now sends its apps a settings frame whenever it joins, changes, or leaves the directory, by any route: the app, another window, `ace directory`, an approved ask, or adopting a peer's. The sidebar card and Settings → Team read the directory again on it, replacing the per-window event that missed the CLI and Ask to join. The asker's "let you in" toast stays until dismissed, since they are often at their teammate's screen during approval. Why: apps/host/src/directory.ts#function configure | every join or leave tells the running host's apps (chose), so their directory views never need a reload
This was referenced Oct 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host now tells its apps (a
settingsframe) whenever it joins, changes, or leaves the team directory, by any route: this app, another window,ace directory <url>|off, an approved Ask to join, or adopting a peer's directory. The sidebar Team directory card and Settings → Team read the directory again on it, so neither needs a reload. This replaces the per-windowace:directory-changedevent, which missed the CLI and Ask to join.ace directory offon a Mac that still serves the directory.Map: ^120, ^106, ^882, ^883. Refs #632, #636.
Smoke (isolated
bun ace serve --port 4990, own home, config, and keychain service; headless Chromium on the built app):ace directory off→ gone afterace directory <url>, all without a reload.ace directory offandace directory <url>live.Built in Ace
No. Made by a Claude Code fix-train worker in a lane, with headless Chromium for the smoke test, since the fix train runs outside Ace (#5).