[workshop-diagrams] Add theme-aware explanatory diagram for conditional logic flow - #2683
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
…G pair - Apply workshop brand palette (#f2f5f3/#101411 backgrounds, #08872b/#5fed83 accents) - Raise all label font sizes to 16px minimum (was 11-13px) - Add data-visual-kind, data-visual-id, data-node, data-state attributes - Use Primer semantic state colors for data-state nodes (done=#1a7f37/#3fb950, skipped=#57606a/#8b949e) - Replace Arial/monospace with Mona Sans / Mona Sans Mono font stack - Remove Unicode emoji from text nodes; use text labels only - Minimum 2px connector strokes with proper arrow markers - Verified via Playwright: light currentSrc ends -light.svg, dark currentSrc ends -dark.svg Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the existing
15-conditional-flowSVG pair inworkshop/15-conditional-logic.mdfrom ad-hoc GitHub Primer colors to a fully brand-compliant light/dark pair.Workshop file changed
workshop/15-conditional-logic.md— the<picture>block already existed; the two SVG files it references were rebuilt to match the workshop brand palette and accessibility requirements.Change type: Migration of existing diagram
The diagram content, geometry, layout, and alt text are preserved. This is a visual quality improvement, not new content.
SVG files updated
workshop/images/15-conditional-flow-light.svgworkshop/images/15-conditional-flow-dark.svgWhy the diagram helps learners
The conditional logic flow is a foundational concept — it shows how a deterministic shell step gates the AI agent job. The diagram already existed but used off-brand Primer colors, font sizes below the 16px diagram label minimum, no
data-visual-kind/data-visual-id/data-nodemetadata, and Unicode emoji in<text>nodes (which the SVG visual language check flags as violations).Changes made
#f2f5f3/#101411backgrounds,#08872b/#5fed83accentsdata-visual-kind/data-visual-id<svg>data-node/data-state<text>nodesQA
SVG_FILES=... node scripts/check-svg-visual-language.js— 0 violationscurrentSrcends with-light.svgcurrentSrcends with-dark.svgWarning
Firewall blocked 9 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comawmgmcpgclients2.google.comclientservices.googleapis.comhost.docker.internalredirector.gvt1.comwww.google.comwww.gstatic.comSee Network Configuration for more information.