Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
server/internal/auditlifecycle.Scanso lifecycle classification and result-status derivation are separate, directly testable functions, and adds one debug log at scan completion. Behavior is unchanged.Action: Reviewer should confirm
Scanbehavior is preserved and the log carries only scalar metadata; acceptance check is passinggo -C server vet ./...andgo -C server test ./....Details
classify(per-rebuild classification and tallies) andresultStatus(ok/attention/incomplete) fromScan. Status precedence is unchanged: incomplete, then attention, then ok.scanLog(cao:auditlifecycle) with one call at scan completion, logging only status, scanned count, finding count and tail-reached flag. Logging is off by default, and the call is outside every loop. It records no rebuild IDs, attributes, or errors.classify_test.gowith table-driven tests that call the real functions on concrete values. They cover terminal, partial-history, gap, zero-time, clock-uncertain, pending and missing-terminal classifications, and the status precedence rules. No mocks or fakes.gofmt,go -C server vet ./...andgo -C server test ./...all passed.Control Plane
40891685100-2895githubnext/gh-cao