Repository navigation
[self-care:server-go-logging] Extract CLI relay workload exit mapping with diagnostic logging - #20017
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the
cao-cli-relayworkload exit-status mapping into a testableworkloadExitCodehelper, preserving behavior, and adds real-process unit tests.Action: Maintainer should review the small refactor in
server/cmd/cao-cli-relay/main.go; accept ifgo -C server vet ./...andgo -C server test ./...pass.Details
server/cmd/cao-cli-relay(first path in rotation; no prior state).command.Run()error handling moved intoworkloadExitCode(err) int: nil → 0, workload exit → its code, otherwise 125 with the same stderr message.cao:cli-relaylogger calls (exit code only, no new calls) are retained; disabled by default; no args, output, or error text logged.exit_test.go): realsh -c "exit 7", missing executable, plain error, and context-cancelled (signal-killed) process; no mocks.go vet ./...andgo test ./...pass.Control Plane
41165660926-3005githubnext/gh-cao