Repository navigation
[self-care:server-go-logging] Extract ADX observation row builder and log projection outcomes - #20049
Merged
pelikhan merged 1 commit intoNov 1, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
marked this pull request as ready for review
November 1, 2026 02:02
pelikhan
deleted the
self-care/server-go-logging-adx-projection-06603e04b8f1c695
branch
November 1, 2026 02:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
server/internal/adxingest/projection.go: the per-observation row construction is extracted fromprojectintoobservationRow, and the projection now emits scalar-only debug logs undercao:adx:projection. Behavior is unchanged.Action: Reviewer should confirm the diff is behavior-preserving and that
go -C server vet ./...andgo -C server test ./...pass.Details
observationRowowns allowlisted field mapping, presence/null tracking, and quality columns.projectkeeps identity checks, digests, sorting, and size limits.TestObservationRowRecordsPresenceAndQualityandTestObservationRowRejectsInvalidValues.go -C server vet ./...andgo -C server test ./...pass.Control Plane
41251237617-3063githubnext/gh-cao