-
Notifications
You must be signed in to change notification settings - Fork 291
feat(theme): add Glass design language #3130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
afonsojramos
wants to merge
27
commits into
main
Choose a base branch
from
native-theme-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,430
β135
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
aced5c0
feat(theme): add useAppearance hook with design-language root attributes
afonsojramos 60b7633
feat(theme): add design-language chrome token layer via @theme inline
afonsojramos 15f3245
refactor(theme): route renderer through app-owned ui/ layer with impoβ¦
afonsojramos bc29091
feat(theme): add design-language settings axis with Classic/Glass selβ¦
afonsojramos d87fd88
refactor(theme): trim non-essential comments
afonsojramos 6289fa8
feat(theme): add Glass shell surfaces with per-platform material branch
afonsojramos 98ea376
feat(theme): wire macOS window vibrancy via IPC for Glass
afonsojramos 74f6c25
feat(theme): degrade Glass to solid under reduced transparency / contβ¦
afonsojramos 06dcfde
feat(theme): desaturate Glass status palette toward a native tone
afonsojramos 760e4e9
fix(theme): construct a transparent vibrant window on macOS so Glass β¦
afonsojramos ee83c29
feat(theme): dissolve sidebar into unified Glass and mute the primaryβ¦
afonsojramos 2321fc0
feat(theme): soften notification grouping bands and count pills underβ¦
afonsojramos 3c95c11
feat(theme): make Glass translucency always-on and add a visible sideβ¦
afonsojramos bb071c4
feat(theme): make the sidebar logo follow the icon colour under Glass
afonsojramos 8b9e6ce
feat(theme): lighten Glass tints, soften blur, and use a translucent β¦
afonsojramos 2344322
chore(dev): quiet codegen and Chromium dev logs, skip auto-launch in dev
afonsojramos 2321176
fix(theme): make Glass vibrancy show the real desktop on macOS
afonsojramos 8969c46
feat(theme): refine Glass surfaces
afonsojramos b699d97
fix(theme): keep Glass translucent after a runtime Classic to Glass sβ¦
afonsojramos 66b21a5
fix(theme): harden the native-theme sync
afonsojramos 576624f
feat(theme): apply Glass to controls, list rows, and overlays
afonsojramos af53366
refactor(components): import Primer directly instead of the ui barrel
afonsojramos 9d03ba5
revert(dev): restore codegen dotenv warning behavior
afonsojramos 51408e0
feat(theme): float the Glass account header directly on the glass
afonsojramos 01615ab
feat(theme): bare the Glass account-profile button inside account cards
afonsojramos bba2ca8
feat(theme): re-add high contrast for Classic, driven by the setting β¦
afonsojramos 49ee263
refactor(settings): drop the redundant "value display" comments
afonsojramos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wasn't able to find where in macOS System Settings the vibrancy setting is. Can you point me in the right direction :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isnβt a βvibrancyβ toggle as such. Vibrancy is the native translucency material (NSVisualEffectView) that macOS uses for menus, sidebars, the menu bar and so on. We just ask the OS for it via the windowβs vibrancy option, which is what gives Glass its frosted look. The one user-facing control that affects it is System Settings β Accessibility β Display β βReduce transparencyβ: switch that on and macOS renders these materials solid, which we honor (the window falls back to a solid surface via prefers-reduced-transparency).