Skip to content

feat: add network marker to tests requiring network access #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcepl wants to merge 1 commit into from
Closed

feat: add network marker to tests requiring network access #2337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ testpaths = "test" # Space separated list of paths from root e.g test tests doc
# -ra # test summary: list all non-passing (fail, error, skip, xfail, xpass)
# --ignore-glob=**/gitdb/* # ignore glob paths
# filterwarnings ignore::WarningType # ignores those warnings
markers = [
"net: tests requiring network access",
Comment thread
Byron marked this conversation as resolved.
Resolved
]

[tool.mypy]
files = ["git/", "test/test_typing.py", "test/test_remote_progress.py"]
Expand Down
3 changes: 3 additions & 0 deletions test/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

from gitdb import OInfo

import pytest

from git import Repo
from git.objects import Blob, Commit, TagObject, Tree
import git.objects.base as base
Expand Down Expand Up @@ -122,6 +124,7 @@ def test_with_rw_repo(self, rw_repo: Repo):
assert osp.isdir(osp.join(rw_repo.working_tree_dir, "lib"))
assert osp.isdir(rw_repo.working_dir)

@pytest.mark.net
@skipIf(sys.platform == "win32", "FIXME: Freezes! sometimes...")
@with_rw_and_rw_remote_repo("0.1.6")
def test_with_rw_remote_and_rw_repo(self, rw_repo, rw_remote_repo):
Expand Down
2 changes: 2 additions & 0 deletions test/test_remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ def _assert_push_and_pull(self, remote, rw_repo, remote_repo):
TagReference.delete(rw_repo, new_tag, other_tag)
remote.push(":%s" % other_tag.path, kill_after_timeout=10.0)

@pytest.mark.net
@skipIf(sys.platform == "win32", "FIXME: Freezes!")
@with_rw_and_rw_remote_repo("0.1.6")
def test_base(self, rw_repo, remote_repo):
Expand Down Expand Up @@ -1031,6 +1032,7 @@ def test_ls_remote_unsafe_options_allowed(self, rw_repo):
with self.assertRaises(GitCommandError):
rw_repo.git.ls_remote(".", **unsafe_option, allow_unsafe_options=True)

@pytest.mark.net
@with_rw_and_rw_remote_repo("0.1.6")
def test_fetch_unsafe_branch_name(self, rw_repo, remote_repo):
# Create branch with a name containing a NBSP
Expand Down
Loading