Repository navigation
3.1.0 follow-ups: reading card, one button blue, Edit in the long press, "+" in a closed vault - #30
Merged
Merged
Conversation
Since 3.0.0, "+" in a closed vault asked for its secret, then did nothing: the vault opened and the user had to tap "+" again — an accepted gesture dropped in silence, the very thing HomeRoute's comments refuse everywhere else. Seen on the emulator while testing 3.1.0; Patrice: "corrige-le". The creation now waits for the vault like the long-press gestures do, in GestesDeNoteEnCours: it runs once that vault is unlocked, once only, and is given up with its unlock sheet — dismissed, or moved to another vault. The protection does not move: HomeViewModel.createNote still seals the note in the same transaction as its insert, and still refuses a vault that closed in between. Tests: GestesDeNoteEnCoursTest +2 (created once the vault is open and once only, not for another vault; given up with its sheet or with the secret). Unit tests 464/0, detekt, ktlint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Patrice, 2026-10-10: the "New note", "Edit", "New folder" and "Check for updates" buttons on the blue of the checkerboard with white text — "que toute l'appli soit harmonisée". So every filled button that is not destructive now takes it: also Unlock and Validate (app lock), Close (end of panic mode), Retry (start-up failure) and the three buttons of the vault sheets. The blue is SemanticColors' BLEU_DAMIER (#0B60C5, read from the logo), already the messages' background: named once more as primaryButton/onPrimaryButton, not defined twice. couleursDeBoutonPrincipal() gives the filled buttons their colours; the two floating ones take the pair directly. Disabled buttons keep Material's grey. Kept red, on purpose: erasing after a forgotten PIN and confirming the panic mode — there the colour says the danger. Contrast (SemanticColorsTest, new case): white on the blue 6.0:1 (AA 4.5); the button against the background 5.65:1 light, 3.15:1 dark (WCAG 1.4.11, 3:1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sh in red
Asked by Patrice on 2026-10-10 while testing 3.1.0 on his phone.
- Reading card ("Fiche", his choice among three sketches): the note sits on the screen as a card,
rounded, with its pastel background and a 2 dp border of its colour — the plain card and a grey
border without one —, a slight shadow, its title at the top, a thin rule, the text, and "Last
modified" with its date at the bottom (the Info panel's own string, five languages). The date is
the saved note's: the editor takes back the row it saved.
- Long press: "Edit" first in the sheet, opening the note straight on the writing side. The editor
route takes an optional `ecrire` argument (Destination.Editor), absent from every other route; a
closed vault's note gets the sheet only once its vault is open, and the editor asks for its secret
again if it closed meanwhile.
- "Move to trash" in red in the ⋮ menu — and in the long-press sheet, so that the same gesture has
the same colour everywhere. EntreeDeMenu gains `destructive` (title and icon red); `tint` alone still
colours the icon only, for the vault entries' red padlock. Deleting a folder takes it too.
Found by the palette test, fixed: the reading card puts the links (`primary`) on the note's colour, and
the light pink left them at 4.47:1, under AA. The pink is paler (#FDEDF4: links 4.60:1, secondary text
4.65:1); CouleursDeNoteTest now measures the links on every colour, both themes.
Tests: unit 465/0; on the emulator EditeurTest 33/33, end to end 3/3, home 16/16. detekt, ktlint.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…white folder chip
Patrice, 2026-10-10, after testing on his phone:
- "Move to trash" is neutral again, in the ⋮ menu and in the long-press sheet — it can be undone.
- The ⋮ menu gains "Delete permanently", last and in red, after the trash's own confirmation, as from
the list. The editor leaves once the note is gone, as after the trash. The confirmation closes when
the note stops being readable (vault locked), and NoteEditorViewModel.deletePermanently checks the
vault again at execution — erasing a sealed note needs no key, so this check is the protection.
- The folder chip on the cards: a white background and a grey border instead of the grey fill.
`background` is white in the light theme; in the dark one it is the screen's dark — kept so, on his
word ("laisse comme ça pour le thème sombre").
Tests on the emulator: EditeurTest 33/33 (the menu test presses the new entry), AccueilTest 16/16.
Unit tests, detekt, ktlint green.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ought up to date Patrice: "mets tout à jour", before the release. - Changelogs 5011-5013, five languages (351-403 characters, under F-Droid's 500): the reading card, "Edit" in the long press, the checkerboard blue, "+" in a closed vault were missing. - Store descriptions: the long press offers "Edit" too. - README (English and French): version 3.1.0, a "What's new in 3.1.0" above the 3.0.0 one (kept), "Edit / Preview" replaced by reading and writing, colours in the features, the universal APK's name. - SECURITY.md / SECURITY.fr.md: current version 3.1.0, and what 3.1.0 changes for security — the vault checked at execution before a keyless trash or erase, the colour outside the vault's envelope like the tags, the reading mode's protections, schema 10, the reviews and audit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Patrice: "que tout soit aligné", README, descriptions, legal texts. - THIRD_PARTY_NOTICES.md: read again from the resolved releaseRuntimeClasspath of 3.1.0 — Compose BOM 2026.09.00 (UI 1.12.1, Material 3 1.4.0), Hilt 2.60.1 / Hilt Navigation 1.4.0, Kotlin 2.4.10; the rest unchanged (Room 2.8.5, SQLCipher 4.16.0, Bouncy Castle 1.86, markdown 0.7.14, Okio 3.4.0…). - README (English and French): the intro named "Markdown preview", gone with 3.1.0 — now the notes read as cards in their colour. Also, outside the repository: its GitHub description and topics. The topics still said `flutter`, two versions after the rewrite in Kotlin — now `kotlin` and `jetpack-compose`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to 3.1.0, asked by Patrice while testing it on his phone (2026-10-10). Part of 3.1.0, still untagged.
ecrireroute argument).Contrast measured, not eyeballed: white on the blue 6.0:1; the button against the background 5.65:1 / 3.15:1; the reading card's links on every colour — the light pink failed (4.47:1) and was paled (#FDEDF4, 4.60:1).
🤖 Generated with Claude Code