Fix process.process.exit typo in the test harness error path#2965
Merged
Conversation
When main() rejects (e.g. a fixture setupCommand fails on a network flake), the catch handler crashed with "Cannot read properties of undefined (reading 'exit')" instead of exiting cleanly, burying the real error under a TypeError. Introduced in 232e259. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/test.ts's top-level catch handler hasprocess.process.exit(1)(typo from 232e259, when theexitpackage was replaced). It only executes whenmain()rejects — first seen today on #2964, where a curl SSL flake in the cJSON fixture setup rejectedmain()and the handler crashed withTypeError: Cannot read properties of undefined (reading 'exit'), burying the actual error. Exit code was 1 either way; this just restores honest diagnostics.🤖 Generated with Claude Code