fix(effect, python): validate date and time formats - #3512
Open
schani wants to merge 2 commits into
Open
Conversation
schani
force-pushed
the
agent/effect-date-time-validation-v2
branch
2 times, most recently
from
September 7, 2026 14:49
aa8150b to
d48f728
Compare
schani
force-pushed
the
agent/javascript-prototype-map
branch
from
September 7, 2026 14:52
eb56530 to
3287732
Compare
schani
force-pushed
the
agent/effect-date-time-validation-v2
branch
from
September 7, 2026 14:52
d48f728 to
d04cf44
Compare
Generated-output differences67 files differ — 67 modified, 0 new, 0 deleted |
schani
force-pushed
the
agent/javascript-prototype-map
branch
from
September 7, 2026 15:05
3287732 to
78b0921
Compare
schani
force-pushed
the
agent/effect-date-time-validation-v2
branch
from
September 7, 2026 15:06
d04cf44 to
a60f469
Compare
schani
force-pushed
the
agent/javascript-prototype-map
branch
from
September 7, 2026 15:08
78b0921 to
a3a3db9
Compare
schani
force-pushed
the
agent/effect-date-time-validation-v2
branch
from
September 7, 2026 15:08
a60f469 to
da03633
Compare
Generated-output differences67 files differ — 67 modified, 0 new, 0 deleted |
schani
force-pushed
the
agent/javascript-prototype-map
branch
2 times, most recently
from
September 7, 2026 15:20
5e700f5 to
345ba7c
Compare
schani
force-pushed
the
agent/effect-date-time-validation-v2
branch
from
September 7, 2026 15:21
da03633 to
7d7a498
Compare
Generated-output differences67 files differ — 67 modified, 0 new, 0 deleted |
schani
force-pushed
the
agent/javascript-prototype-map
branch
from
September 7, 2026 15:25
345ba7c to
d7cb7d8
Compare
schani
force-pushed
the
agent/effect-date-time-validation-v2
branch
from
September 7, 2026 15:25
7d7a498 to
6a364ab
Compare
Generated-output differences67 files differ — 67 modified, 0 new, 0 deleted |
schani
force-pushed
the
agent/effect-date-time-validation-v2
branch
from
September 7, 2026 17:55
6a364ab to
86e638b
Compare
schani
changed the base branch from
agent/javascript-prototype-map
to
agent/zod-date-time-validation-v2
September 7, 2026 17:55
Generated-output differences68 files differ — 67 modified, 1 new, 0 deleted |
schani
force-pushed
the
agent/effect-date-time-validation-v2
branch
from
September 7, 2026 18:01
86e638b to
97aadbe
Compare
Generated-output differences67 files differ — 67 modified, 0 new, 0 deleted |
Generated-output differences101 files differ — 101 modified, 0 new, 0 deleted |
schani
changed the title
schani
force-pushed
the
agent/zod-date-time-validation-v2
branch
from
September 8, 2026 02:44
d328bcc to
31267ac
Compare
schani
force-pushed
the
agent/effect-date-time-validation-v2
branch
from
September 8, 2026 02:45
2eeb64d to
94441d5
Compare
schani
changed the title
Generated-output differences101 files differ — 101 modified, 0 new, 0 deleted |
schani
force-pushed
the
agent/effect-date-time-validation-v2
branch
from
September 8, 2026 03:05
94441d5 to
4ba516e
Compare
Generated-output differences101 files differ — 101 modified, 0 new, 0 deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect schemas accepted impossible dates and out-of-range times because their patterns only checked digit counts. Validate date, time, and date-time bounds while retaining lowercase RFC 3339 separators.
Python's generated parser also used permissive parsing that accepted malformed values such as
"1". Use ISO-specific parsers for generated date, time, and date-time conversion.Depends on #3505 and exercises its shared date/time cases. Python #3518 was merged into this branch.
Production diff: Effect 6 lines; Python 4 lines.
Validation: