fix: validate native ISO date-times - #3520
Merged
Merged
Conversation
Generated-output differences94 files differ — 94 modified, 0 new, 0 deleted |
schani
force-pushed
the
agent/javascript-prototype-map
branch
from
September 7, 2026 17:55
d7cb7d8 to
7ec5b2c
Compare
schani
force-pushed
the
fix/php-invalid-date-time
branch
from
September 7, 2026 18:00
650da46 to
a6a5f5a
Compare
schani
changed the base branch from
agent/javascript-prototype-map
to
fix/swift-lowercase-rfc3339
September 7, 2026 18:00
schani
force-pushed
the
fix/swift-lowercase-rfc3339
branch
from
September 7, 2026 18:02
c74b8d4 to
5261688
Compare
schani
force-pushed
the
fix/php-invalid-date-time
branch
from
September 7, 2026 18:02
a6a5f5a to
f5f8445
Compare
Generated-output differences94 files differ — 94 modified, 0 new, 0 deleted |
Member
Author
|
No tests!?!?!?! |
Member
Author
|
|
Generated-output differences94 files differ — 94 modified, 0 new, 0 deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP accepted impossible calendar dates; Objective-C and C++ also accepted malformed RFC 3339 timestamps. PHP now checks parser warnings, while Objective-C and C++ validate the full timestamp and calendar date.
date-time.12.fail.date-time.jsonadds this PR's regression coverage: all three renderers accepted month zero before the fix and reject it afterward.Depends on #3515. Shared calendar and fractional cases remain in the following Swift PRs after every affected backend supports them.
Production diff: PHP 8 lines, Objective-C 5, C++ 2; 15 total.
Validation: build, lint, and the date-time schema pass for 18 available backends: JavaScript, PropTypes, TypeScript, Zod, Effect, Go, Python, Dart, Swift, Objective-C, PHP, C++, Java, Rust, Kotlin, Kotlin/Jackson, Scala 3, and Scala 3/upickle. C# could not run locally because only .NET 10 is installed and the fixture targets .NET 8.