fix(java): reject invalid calendar dates - #3523
Closed
schani wants to merge 8 commits into
Closed
Conversation
Generated-output differences638 files differ — 638 modified, 0 new, 0 deleted |
Member
Author
|
This does't have tests!!! |
schani
force-pushed
the
fix/java-strict-calendar
branch
from
September 8, 2026 01:04
3c3d4d6 to
5e404d2
Compare
Member
Author
|
Added a unit regression that checks strict calendar emission for date-time output, its absence from unrelated output, and preservation of a user type named |
Generated-output differences638 files differ — 638 modified, 0 new, 0 deleted |
Base automatically changed from
fix/php-invalid-date-time
to
fix/swift-lowercase-rfc3339
September 8, 2026 02:45
schani
force-pushed
the
fix/swift-lowercase-rfc3339
branch
from
September 8, 2026 02:47
c07cb7d to
f362b87
Compare
schani
force-pushed
the
fix/java-strict-calendar
branch
from
September 8, 2026 02:47
5e404d2 to
02215b0
Compare
Generated-output differences638 files differ — 638 modified, 0 new, 0 deleted |
schani
force-pushed
the
fix/swift-lowercase-rfc3339
branch
from
September 8, 2026 03:05
f362b87 to
8dd8013
Compare
Member
Author
|
Superseded by #3521, which combines the Java and Swift fixes with shared invalid-calendar cases 9 and 11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jackson normalizes impossible calendar dates such as 2023-02-29 instead of rejecting them. Parse date-time values with a strict formatter so generated Java converters reject calendar rollovers.
The strict resolver is emitted only when the graph contains date-time values. A unit regression verifies its presence for date-time output, its absence otherwise, and preservation of a user type named
ResolverStyle. Shared invalid-calendar fixture cases remain in #3521, after every affected backend supports them.Production diff: 15 lines changed.
Validation: