Skip to content

fix: align caption font size with subtitle2 (PGE-142765) - #1143

Merged
Yayo-Arellano merged 2 commits into
v4from
feature/pge-142765
Sep 9, 2026
Merged

Yayo-Arellano merged 2 commits into
v4from
feature/pge-142765

Conversation

@iu-glints

Copy link
Copy Markdown
Collaborator

Summary

Raise the @next caption desktop font size from 12px to 13px to match subtitle2 in Aries 4.1.82. Both variants continue to use 12px at widths up to 768px.

Adjust the caption skeleton height from 16.8px to 18.2px for its 140% line height, retaining 16.8px at the mobile breakpoint. Update the existing typography and skeleton metric tests.

Requested by Tung An.
Task: https://applink.larksuite.com/client/todo/detail?guid=f5ed588b-63f8-4ec6-96ec-83de75193a38&suite_entity_num=t142765

Verification

  • Node 16.20.2, matching .nvmrc.
  • Typography and SkeletonText Jest suites: 31 tests passed.
  • Changed-file ESLint, Stylelint, and Prettier checks passed.
  • Repository pre-commit hook passed yarn lint:fix and yarn lint.
  • git diff --check passed; working tree clean after commit.

Dependency installation hit the host disk limit. Checks used an existing Aries dependency directory with an identical yarn.lock. Full build and visual checks are left to CI.

Release

Requires an Aries package release and a subsequent Employers dependency update before this change appears in Employers.

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

@iu-glints

Copy link
Copy Markdown
Collaborator Author

Fixed the visual-test failures in ea76448.

The 13px captions changed DataTable and IndexTable header widths, line boxes, and their sorting/hover/loading screenshots. Regenerated and reviewed 12 existing baselines using mcr.microsoft.com/playwright:v1.29.0-focal. The eight screenshots from the failing CI report matched the locally regenerated images pixel-for-pixel.

All four visual-test shards, validate, and deploy now pass: https://github.com/glints-dev/glints-aries/actions/runs/34205205467

The original shards 3 and 4 were cancelled by matrix fail-fast after shard 2 failed, rather than reporting independent completed test failures.

Before After
DataTable before DataTable after

@Yayo-Arellano, the updated screenshots are ready for review.

@Yayo-Arellano
Yayo-Arellano merged commit 37d4d39 into v4 Sep 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants