Open
Conversation
The "Type" column is of very little use: types can be easily inherited from the Option name. Moreover, that column was present only on few rows, thus causing misalignments. Finally, the table was too large: a horizontal scroller appears on rendered pages, causing a bad UX.
Removed column needs to be removed also from table headers
minor fixes
server.allow-insecure was duplicated
Sheetalpamecha
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Type" column is of very little use: option types can be easily inherited from the name.
Moreover, the Type field appears only on few rows, thus causing bad misalignments.
Finally, the table was too large: a horizontal scroller appears on rendered pages, causing a bad UX.