Skip to content

Fix issue with refresh of view based NSTableView#403

Open
gcasa wants to merge 6 commits intomasterfrom
NSTableViewDiffableDataSource_fixes
Open

Fix issue with refresh of view based NSTableView#403
gcasa wants to merge 6 commits intomasterfrom
NSTableViewDiffableDataSource_fixes

Conversation

@gcasa
Copy link
Copy Markdown
Member

@gcasa gcasa commented Mar 7, 2026

The issue that I am trying to fix is that when the scrollbar is used the number of rows in the NSTableView shows ONE row and not all. I am not sure why this is happening.

@fredkiefer
Copy link
Copy Markdown
Member

I really would prefer if you could do formatting changes as a separate commit. This can be in the same PR. That way it would be simpler to look through the remaining changes.

@gcasa
Copy link
Copy Markdown
Member Author

gcasa commented Mar 7, 2026

I really would prefer if you could do formatting changes as a separate commit. This can be in the same PR. That way it would be simpler to look through the remaining changes.

Okay. Understood. I will do so going forward.

@gcasa
Copy link
Copy Markdown
Member Author

gcasa commented Mar 7, 2026

I am going to see if there are other solutions to this problem before marking it ready.

@gcasa gcasa changed the title Observe the bounds change so that we can refresh the table when it's view based Fix issue with refresh of view based NSTableView Mar 8, 2026
@gcasa gcasa marked this pull request as ready for review March 9, 2026 01:46
@gcasa
Copy link
Copy Markdown
Member Author

gcasa commented Mar 10, 2026

@fredkiefer This is ready for review, I don't think I can simplify it more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants