Implementing specific step size#18
Merged
Merged
Conversation
metalmatze
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a followup of PR #16 (Issue #15), and probably a duplicate of PR #2, although the code is now much newer and it wouldn't have made sense to start from there.
As asked, I implemented a 'resolution' flag that defines the steps of the timeseries, which defaults to 1s if not provided (or a sub-second Duration is provided).
I also updated the tests and reformatted the code using Golang's inbuilt formatter.
Please let me know if any additional modification is to be done.