Fix slice deep map (owned) #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am impacted by this issue as well, and currently need to maintain a vendored copy of the library which includes this patch in order to solve for my use cases. |
|
+1 |
ayratsa
approved these changes
Nov 8, 2025
|
@sagikazarmark Hi, can you provide a review so we can merge this PR? |
Member
|
Looks good to me, thanks @jphastings ! I'll run the tests later locally, because CI is stuck. But I don't expect any issues and will merge it soon. |
Author
|
Thanks! Don't hesitate to let me know if it needs any extra work 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements deep mapping of nested slices of structs.
Two people (originally @mullerch, whose work this is, and later @ayratsa who transferred the PR to the go-viper owned blessed fork) have submitted this PR, but the change of hands of the repo & the rest of life appears to have gotten in the way.
I'm re-submitting this PR with:
mainresolvedFixes #19
Fixes #125