Repository navigation
Rasterise SVG with go-gfx/oksvg: clipPath, multi-set arcs - #298
Merged
Merged
Conversation
…al parameter sets The import and the requirement change from srwiley/oksvg (unmaintained since 2022, no clipPath) to its fleet fork go-gfx/oksvg, which adds clipPath and fixes arc commands with several parameter sets. No engine logic changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the SVG rasteriser from
srwiley/oksvg(last commit 2022-10-11, noclipPath) to its fleet fork go-gfx/oksvg v0.1.0, which implementsclipPath(go-gfx/oksvg#2) and fixes arc commands with several parameter sets (twemoji's 🪇 was 45.7% of pixels off Chrome, now 0.03%).The change here is the import path in
svg.goandsvg_test.go,go.mod/go.sum, one test (svg_clip_test.go: a clipped rect throughRasterizeSVG), and the two doc lines that said oksvg has no clipPath. No engine logic changes; the engine package tests pass.Measured on the 4009 Twemoji graphics at 72 px, interleaved rounds: 1.17 to 1.21 s before and after (no slowdown without clipPath); 212 of them draw differently now (the arc fix: flags, runners, ...).
🤖 Generated with Claude Code