Skip to content

Pass release version to shell via env, not interpolation (SEC-11868) - #205

Open
leonard-tesnov wants to merge 1 commit into
masterfrom
sec/11868-workflow-shell-injection
Open

leonard-tesnov wants to merge 1 commit into
masterfrom
sec/11868-workflow-shell-injection

Conversation

@leonard-tesnov

Copy link
Copy Markdown

The release workflow interpolated ${{ steps.version.outputs.version }} directly into three run: bodies. Actions substitutes that textually before the shell runs, so the value is parsed as shell source rather than read as data. The version is read from build.gradle, and one of the affected steps is the one holding the release token.

Bind the value through step-level env: so the shell reads it as data, and reject a version that is not plain semver at the point it is read.

Ref: SEC-11868

The release workflow interpolated ${{ steps.version.outputs.version }}
directly into three `run:` bodies. Actions substitutes that textually
before the shell runs, so the value is parsed as shell source rather
than read as data. The version is read from build.gradle, and one of the
affected steps is the one holding the release token.

Bind the value through step-level `env:` so the shell reads it as data,
and reject a version that is not plain semver at the point it is read.

Ref: SEC-11868

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant