Skip to content

remove caching of the LIBNAME in CMake configuration#113

Merged
Ivorforce merged 1 commit intogodotengine:mainfrom
van800:libname
Mar 18, 2026
Merged

remove caching of the LIBNAME in CMake configuration#113
Ivorforce merged 1 commit intogodotengine:mainfrom
van800:libname

Conversation

@van800
Copy link
Contributor

@van800 van800 commented Mar 17, 2026

This change lets the generated run configuration in Rider/CLion to updated as soon as the library name is changed, fixes https://youtrack.jetbrains.com/issue/RIDER-136871

Specifically:

  1. Rename "EXTENSION-NAME" to "NEW-NAME" and reloading CMake should update the run-configuration
image

When the name is CACHED, only manual removal of the cmake-build-debug folder would help to regenerate the run configuration.

There is also another problem with the cached name even outside of Rider/CLion.
If you rename the library and call cmake --build /Users/ivan.shakhov/Projects/MyExtension/cmake-build-debug --target all -- -j 14, using the previously used folder cmake-build-debug, it would build the library with the previously cached name.

…ated run configuration in Rider/CLion to updated as soon as the library name is changed, fixes https://youtrack.jetbrains.com/issue/RIDER-136871
@Ivorforce
Copy link
Member

cc @enetheru (i can't request review unfortunately)

@enetheru
Copy link
Contributor

I approve, Initially I thought it would be good to have the variable discoverable via the help command but its not an option per-se, something that would be set and left, rather than tuned for different circumstances. So changing it to a normal var is a good plan. Any such variables that are not strictly options should also be changed, like the project one.

Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enetheru approves, and that's enough for me :-)

@Ivorforce Ivorforce added the bug Something isn't working label Mar 18, 2026
@Ivorforce Ivorforce merged commit c5d45ad into godotengine:main Mar 18, 2026
5 checks passed
@Ivorforce
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants