remove caching of the LIBNAME in CMake configuration#113
Merged
Ivorforce merged 1 commit intogodotengine:mainfrom Mar 18, 2026
Merged
remove caching of the LIBNAME in CMake configuration#113Ivorforce merged 1 commit intogodotengine:mainfrom
Ivorforce merged 1 commit intogodotengine:mainfrom
Conversation
…ated run configuration in Rider/CLion to updated as soon as the library name is changed, fixes https://youtrack.jetbrains.com/issue/RIDER-136871
Member
|
cc @enetheru (i can't request review unfortunately) |
Contributor
|
I approve, Initially I thought it would be good to have the variable discoverable via the help command but its not an option per-se, something that would be set and left, rather than tuned for different circumstances. So changing it to a normal var is a good plan. Any such variables that are not strictly options should also be changed, like the project one. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change lets the generated run configuration in Rider/CLion to updated as soon as the library name is changed, fixes https://youtrack.jetbrains.com/issue/RIDER-136871
Specifically:
When the name is CACHED, only manual removal of the
cmake-build-debugfolder would help to regenerate the run configuration.There is also another problem with the cached name even outside of Rider/CLion.
If you rename the library and call
cmake --build /Users/ivan.shakhov/Projects/MyExtension/cmake-build-debug --target all -- -j 14, using the previously used foldercmake-build-debug, it would build the library with the previously cached name.