Require hot reload to be explicitly enabled#1994
Open
dsnopek wants to merge 1 commit into
Open
Conversation
dsnopek
added
enhancement
enetheru
suggested changes
May 30, 2026
dsnopek
force-pushed
the
disable-reloadable-by-default
branch
from
6072655 to
efdcca7
Compare
dsnopek
force-pushed
the
disable-reloadable-by-default
branch
from
efdcca7 to
6a4a323
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, hot reload is enabled by default on debug builds, however, I've since wished we didn't enable it by default and required developers to opt-in
This was discussed on #1876, where we could have done something better if hot reload was opt-in, but I didn't want the potentially disruptive change
However, now that we're about to release v10, maybe now is the time to do this? It will no longer be as disruptive, because it would be associated with a versioned release that can be documented as an upgrading note
Per #1876, this also rolls back the changes from #1878 and includes the changes from #1877, which I think is the better solution
AI disclosure
I used Claude code for the CMake changes, because I really don't know CMake very well. However, I did test the changes with various options and they seem to work as intended! Human review would be much appreciated (cc @enetheru)