Skip to content
This repository was archived by the owner on Dec 7, 2019. It is now read-only.

Fix js issue when displaying stacktraces in report#161

Open
f-lolom wants to merge 1 commit into
gojuno:masterfrom
f-lolom:master
Open

Fix js issue when displaying stacktraces in report#161
f-lolom wants to merge 1 commit into
gojuno:masterfrom
f-lolom:master

Conversation

@f-lolom

@f-lolom f-lolom commented Dec 11, 2018

Copy link
Copy Markdown

Hi everyone,

everything is in the title : the JS in TestItem.js is broken. The following error occurs in the JS console when opening a "test details" page:

Uncaught TypeError: Cannot read property 'length' of undefined
    at t.value (app.min.js:25)
    at app.min.js:97
    at s (app.min.js:97)
    at h._renderValidatedComponentWithoutOwnerOrContext (app.min.js:97)
    at h._renderValidatedComponent (app.min.js:97)
    at h.performInitialMount (app.min.js:97)
    at h.mountComponent (app.min.js:97)
    at Object.mountComponent (app.min.js:6)
    at g.mountChildren (app.min.js:97)
    at g._createInitialChildren (app.min.js:97)

Concretely, this error was preventing the "title" and the "screenshot" section to be displayed to the user.

The bug was introduced by this commit : b0c12ea

@tir38

tir38 commented Apr 26, 2019

Copy link
Copy Markdown

@artem-zinnatullin @yunikkk @ming13 Can you 👀 when you have time? This one-line fix would help us out a lot.

@adrey adrey left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine

@tir38

tir38 commented May 16, 2019

Copy link
Copy Markdown

@f-lolom I don't suppose you'd be willing to rebase this PR and issue a new version of your own lib to capture this one more-recent commit 2ff3f57

@nimeacuerdo

Copy link
Copy Markdown

Hi, any news on this?

@nimeacuerdo

Copy link
Copy Markdown

This is working for us in the meantime.

The issue was causing the following JS error :
Uncaught TypeError: Cannot read property 'length' of undefined
@flolom

flolom commented Jun 28, 2019

Copy link
Copy Markdown

@tir38 I've updated my fork : com.flolom.composer:composer:0.6.1

@tir38

tir38 commented Aug 2, 2019

Copy link
Copy Markdown

@f-lolom thanks that worked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants