SVS 1196 - Full load logic for permissions provisioning#1120
Merged
janmatzek merged 2 commits intogooddata:masterfrom Aug 29, 2025
Merged
Conversation
janmatzek
force-pushed
the
jmat-svs-1196-full-load-logic-for-permissions-provisioning
branch
from
ca5f5cd to
1aaa7be
Compare
janmatzek
changed the title
janmatzek
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
hkad98
reviewed
Aug 28, 2025
|
|
||
|
|
||
| class PermissionType(Enum): | ||
| class PermissionType(str, Enum): |
Contributor
There was a problem hiding this comment.
Just add a comment, please, that with 3.11 we should start using StrEnum
Contributor
Author
There was a problem hiding this comment.
Yup. Made a similar comment for the return type on L45, with 3.11 it could be made simpler with typing.Self
hkad98
reviewed
Aug 28, 2025
| is_active: bool | ||
| class ConstructorMixin: | ||
| @staticmethod | ||
| def _get_id_and_type( |
Contributor
There was a problem hiding this comment.
Why is there an underscore at the beginning?
Contributor
Author
There was a problem hiding this comment.
It's a Python convention for "private" methods - it's not enforced at runtime, though.
Contributor
There was a problem hiding this comment.
Yes, I know but the combination with @staticmethod seems a little bit strange to me.
hkad98
reviewed
Aug 29, 2025
hkad98
reviewed
Aug 29, 2025
janmatzek
force-pushed
the
jmat-svs-1196-full-load-logic-for-permissions-provisioning
branch
from
9dac3e2 to
c129583
Compare
hkad98
approved these changes
Aug 29, 2025
janmatzek
deleted the
jmat-svs-1196-full-load-logic-for-permissions-provisioning
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: svs-1196