Skip to content

Add suport for HTTP_PROXY/HTTPS_PROXY variables#1587

Open
koles wants to merge 1 commit intogooddata:masterfrom
koles:feature/https_proxy_support
Open

Add suport for HTTP_PROXY/HTTPS_PROXY variables#1587
koles wants to merge 1 commit intogooddata:masterfrom
koles:feature/https_proxy_support

Conversation

@koles
Copy link
Copy Markdown

@koles koles commented May 7, 2026

Motivation

  • API access from restricted environments

Summary

  • Add optional proxy parameter to GoodDataApiClient and GoodDataSdk.create()
  • Auto-detect proxy from HTTPS_PROXY / https_proxy / HTTP_PROXY / http_proxy environment variables when no explicit proxy is provided
  • Explicit proxy parameter takes precedence over environment variables

Test plan

  • Unit tests for explicit proxy parameter
  • Unit tests for env variable detection (all four variants)
  • Unit tests for precedence (HTTPS_PROXY > HTTP_PROXY, explicit > env)
  • Unit tests for no-proxy case
  • Integration through GoodDataSdk.create()

@koles koles requested review from hkad98, jaceksan, lupko and pcerny as code owners May 7, 2026 03:50
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.83%. Comparing base (efc6b2a) to head (bb667f9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1587   +/-   ##
=======================================
  Coverage   78.83%   78.83%           
=======================================
  Files         230      230           
  Lines       15486    15491    +5     
=======================================
+ Hits        12208    12213    +5     
  Misses       3278     3278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koles koles force-pushed the feature/https_proxy_support branch from 602305e to 12c8d84 Compare May 7, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant