Skip to content

encoder: fix holdout splitting and compatibility wrapper #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangyz0918 merged 1 commit into from
Sep 16, 2026
Merged

encoder: fix holdout splitting and compatibility wrapper #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions proeval/encoder/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def split_train_and_target(
"""
# Start with all benchmarks except target benchmark
train_data = {
k: v for k, v in benchmark_data.items() if k != target_benchmark
k: dict(v) for k, v in benchmark_data.items() if k != target_benchmark
}

# New Model setting: Exclude target model from ALL other benchmarks as well!
Expand Down Expand Up @@ -277,6 +277,5 @@ def prepare_holdout_split(
benchmark_data,
target_benchmark=holdout_benchmark,
target_model=target_model,
include_target_benchmark_in_training=True,
setting="new_pair",
)