Repository navigation
sampler: align GMM selection with the paper - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct source-selection differences found by comparing the implementation with Sections 2.2.3 and E.2.2鈥揈.3 of the paper: https://arxiv.org/html/2604.23099v1
ValueErrorwhen fewer than three source models in the target cluster are available on the target benchmark. Do not silently substitute unrelated models from other clusters.Compatibility
The return signature is unchanged. Source choices and estimates can change because the feature construction is corrected. Small clusters now explicitly abstain; this is intentional, not a fallback to all sources. Missing models on a reference benchmark retain mean imputation, now per question; explicitly present score columns must be finite.
Verification
123 passed, including PyTorch paths.gemini25_flash; GSM8K explicitly abstains for its empty source cluster.