Repository navigation
Fix linear GP posterior variance - #20
Merged
huangyz0918 merged 1 commit intoSep 28, 2026
Merged
Conversation
Member
|
You are right @AlKeshi Thank you for the PR! |
huangyz0918
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @huangyz0918 can you check the following issue?
For the linear kernel,
get_posterior_embeddinguses1instead of||phi(x)||虏for the prior diagonal, so a valid zero feature can incorrectly gain variance from 0 to 1 after conditioning and alter SS selection.This adds two production lines to use the correct diagonal and one regression test.