Skip to content

refactor: restrict Token Creator role to self-impersonation in setup script #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidAPierce wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: restrict Token Creator role to self-impersonation in setup script #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scripts/setup_workload_identity.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,13 +347,13 @@ gcloud projects add-iam-policy-binding "${GOOGLE_CLOUD_PROJECT}" \
--member="serviceAccount:${SERVICE_ACCOUNT_EMAIL}" \
--condition=None

# Allow the service account to generate an access tokens
print_info "Granting 'Service Account Token Creator' role to Service Account..."
# Allow the service account to generate an access tokens (self-impersonation only)
print_info "Granting 'Service Account Token Creator' role to Service Account (self-impersonation)..."

gcloud projects add-iam-policy-binding "${GOOGLE_CLOUD_PROJECT}" \
gcloud iam service-accounts add-iam-policy-binding "${SERVICE_ACCOUNT_EMAIL}" \
--project="${GOOGLE_CLOUD_PROJECT}" \
--role="roles/iam.serviceAccountTokenCreator" \
--member="serviceAccount:${SERVICE_ACCOUNT_EMAIL}" \
--condition=None
--member="serviceAccount:${SERVICE_ACCOUNT_EMAIL}"

# Grant logging permissions to the service account
print_info "Granting 'Logging Writer' role to Service Account..."
Expand Down
Loading