Resolving class thresholding mismatch (8 -> 15) in kitti.py#76
Open
david-wei-01001 wants to merge 1 commit intogoogle-research:masterfrom
Open
Resolving class thresholding mismatch (8 -> 15) in kitti.py#76david-wei-01001 wants to merge 1 commit intogoogle-research:masterfrom
david-wei-01001 wants to merge 1 commit intogoogle-research:masterfrom
Conversation
david-wei-01001
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the preprocess function _count_all_pp(), _count_left_pp(), _count_far_pp(), and _count_near_pp(), the comment says they will be thresholded at 15, and later these tasks all have 16 labels. However, in the code they are actually thresholded at 8, leading to 9 classes. I have changed 8 -> 15 to mach the comment as well as the class numbers.