fix(lit, angular): correct DateTimeInput month indexing [Issue #566]#568
Open
shantoislamdev wants to merge 4 commits intogoogle:mainfrom
Open
fix(lit, angular): correct DateTimeInput month indexing [Issue #566]#568shantoislamdev wants to merge 4 commits intogoogle:mainfrom
shantoislamdev wants to merge 4 commits intogoogle:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where DateTimeInput components were using 0-indexed months, causing date inputs to appear empty. The fix is applied consistently to both the Lit and Angular renderers by adding 1 to the result of date.getMonth(). The changes are clear, correct, and include explanatory comments. The code quality is good, and I have no further suggestions for improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
DateTimeInputcomponent in both Lit and Angular renderers to use 1-indexed months (01-12) instead of 0-indexed months (00-11) for the HTML date input value.Fixes #566
Problem
The
DateTimeInputcomponent incorrectly formatted thevalueattribute for<input type="date">by usingdate.getMonth()directly (which is 0-indexed).Impact:
2025-00-01.Solution
Updated the date formatting logic in both renderers:
renderers/lit/src/0.8/ui/datetime-input.ts- Line:137-138renderers/angular/src/lib/catalog/datetime-input.ts- Line97-98Change:
Testing
Checklist